Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #3 #4

Closed
wants to merge 2 commits into from
Closed

Fix issue #3 #4

wants to merge 2 commits into from

Conversation

ariuss
Copy link

@ariuss ariuss commented Oct 28, 2018

Fix #3. The issue is due to outdated ansimd module. I also add package-lock.json for deterministic installation.

@ariuss ariuss changed the title Fix #3 Fix issue #3 Oct 28, 2018
@thejmazz
Copy link
Member

Thanks!

This looks good, but before accepting PR I would like to spin up locally and test. Also not sure how @bmpvieira is managing deploy for this.

It could also be the case that the error came up because you are using a more recent Node than what this repo was made with. Have you been interacting with this via a local npm install, or online? I think online try.bionode.io is down atm (and for something else?) so probably local.

@bmpvieira
Copy link
Member

Thank you @ariuss for this!
@thejmazz this repo is just the npm module to run the tutorial on your terminal. The try.bionode.io stuff is in other repositories (bionode/try-bionode and bionode/get-bionode).
If you approve and merge these changes I can npm publish them manually (we should probably add an automated way to do this).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot access a lesson
3 participants