fix(js_formatter): format hook with 3 arguments #4462
+30
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Formatter
CodSpeed Performance ReportMerging #4462 will not alter performanceComparing Summary
|
|
@vohoanglong0107 FYI remember to add @biomejs/core-contributors too when requesting for code review. If you check the maintainers team, it doesn't contain the members that belong to the core contributors team |
ematipico
requested changes
Nov 5, 2024
There was a problem hiding this comment.
You created the test in the wrong folder, the prettier folder should stay as is. Create a new test inside specs, maybe here: https://github.com/biomejs/biome/tree/main/crates%2Fbiome_js_formatter%2Ftests%2Fspecs%2Fjs%2Fmodule
| @@ -31,3 +31,7 @@ expect( | |||
| bar; | |||
| }, | |||
| ).toThrow(ReferenceError); | |||
|
|
|||
| useImperativeHandle(ref, () => { | |||
There was a problem hiding this comment.
These tests are coming from prettier repository, so they should not be modified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently the hook detection in JS formatter only recognizes hooks with 2 arguments. This PR updates the formatter to also recognize hooks with 3 arguments.
Fix #4262
Test Plan
Added new test with the
useImperativeHandlehook, a 3 arguments hook.