Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): add noGlobalDirnameFilename #4452

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

unvalley
Copy link
Member

@unvalley unvalley commented Nov 2, 2024

Summary

Closes #4331

Add noGlobalDirnameFilename lint rule that disallow the use of __dirname and __filename.
It's a part of eslint-plugin-unicorn/prefer-module lint rule.

And add META_KW ("meta") to construct JsImportMetaExpression.

Test Plan

Add snapshot tests.

@github-actions github-actions bot added A-Project Area: project A-Linter Area: linter A-Parser Area: parser L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis labels Nov 2, 2024
@unvalley unvalley force-pushed the 4331-implement-nolegacypathglobals-rule branch from 6f6525d to f54d561 Compare November 2, 2024 16:59
@github-actions github-actions bot added A-CLI Area: CLI A-Tooling Area: internal tools labels Nov 2, 2024
@github-actions github-actions bot added the A-Changelog Area: changelog label Nov 2, 2024
Copy link

codspeed-hq bot commented Nov 2, 2024

CodSpeed Performance Report

Merging #4452 will not alter performance

Comparing unvalley:4331-implement-nolegacypathglobals-rule (5fb129c) with main (ec46f37)

Summary

✅ 99 untouched benchmarks

@unvalley unvalley marked this pull request as ready for review November 2, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Diagnostic Area: diagnostocis A-Linter Area: linter A-Parser Area: parser A-Project Area: project A-Tooling Area: internal tools L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📎 Implement noGlobalDirnameFilename rule
1 participant