feat: add option to skip arrow function for explicit function return …

[nazarhussain]

Summary

This PR introduce new option allowArrowFunctions to the lint/nursary/useExplicitFunctionReturnType rule.

In larger code base there are a lot of arrow functions used for a lot of inline functionality, mostly to overcome need of passing a function instead of a value. e.g. () => object.attr. Specifying explicit return type for such arrow functions is tedious to do and don't provide a of help, as the TS can infer the return type easily.

This option is similar to allowExpressions option for @typescript-eslint/explicit-function-return-type but not identical.

Test Plan

Tested manually by building binary and testing against a sample code.

Could not find a way to set custom option in the test-docs for specific rule, so could not add new test cases.

[ematipico]

@nazarhussain thank you for your contribution.

We would appreciate it if you'd get involved first with the relative issue: #2017

The issue was assigned to another contributor, which already implemented your use case: #4036

[Conaclos]

We recently renamed the rule to useExplicitTypes, you will have to update your code. Also, we should not add any options. We could just extend the rule.

[codspeed-hq]

CodSpeed Performance Report

Merging #4233 will improve performances by 7.11%

_{Comparing nazarhussain:nh/explicit-return-type (dc0c38b) with main (92286ab)}

Summary

⚡ 1 improvements
✅ 98 untouched benchmarks

Benchmarks breakdown

	Benchmark	main	nazarhussain:nh/explicit-return-type	Change
⚡	react.production.min_3378072959512366797.js[cached]	2 ms	1.9 ms	+7.11%

[Conaclos]

These examples should be still invalid.

[Conaclos]

This example seems not related to what we check. We could remove it.

[Conaclos]

Code example should be in code block.

Suggested change

	/// function getObjectWithFunction(): Behavior {
	/// return {
	/// attribute: 'value',
	/// func: function myFunc(): string { return "value" },
	/// arrowFunc: () => {},
	/// }
	/// }
	/// ```ts
	/// function getObjectWithFunction(): Behavior {
	/// return {
	/// attribute: 'value',
	/// func: function myFunc(): string { return "value" },
	/// arrowFunc: () => {},
	/// }
	/// }
	/// ```

[Conaclos]

This is not enough because this will accept cases we want to reject.
For example, the following case should be rejected:

const x = {
  prop: () => {}
}

In contrast, the following could be accepted:

const X: Type  = {
  prop: () => {}
};
f({  prop: () => {} })

[Conaclos]

This check is to permissive. This accepts too much code.