Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally build only the latest version of a recipe. #99

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

johanneskoester
Copy link
Contributor

No description provided.

@@ -240,11 +241,15 @@ def build_recipes(

logger.info('blacklist: %s', ', '.join(sorted(blacklist)))

get_recipes = utils.get_recipes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is handled in the if below.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean this could be in an else, belonging to the if below.

if latest_only:
    get_recipes = utils.get_latest_recipes
else:
    get_recipes = utils.get_recipes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is right. I did it this way because I thought it better reflects that there is a default case, and a special case (and possibly more in the future).

@epruesse
Copy link
Member

epruesse commented Jan 8, 2019

@johanneskoester - What is the status of this? Is it still needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants