Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add osx-arm64 to platform checks #965

Merged
merged 5 commits into from
Mar 22, 2024
Merged

Conversation

aliciaaevans
Copy link
Contributor

add osx-arm64 to platforms and only build if additional platform is configured

@aliciaaevans aliciaaevans requested a review from daler March 21, 2024 21:09
Copy link
Member

@daler daler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as-is; do you think it is worth thinking about tests at this point, or just wait to see how things look over in recipes?

@jmarshall
Copy link
Member

It's great to see from this and the previous PR that osx-arm64 support is progressing. It would be useful for those looking forward to this functionality if the core cabal could mention this progress (and give a vague idea of what's involved and timelines) in the related conversations on bioconda/bioconda-recipes#33333 or bioconda/bioconda-recipes#37068 or reply to the person who asked about it on gitter.

@aliciaaevans
Copy link
Contributor Author

Looks good as-is; do you think it is worth thinking about tests at this point, or just wait to see how things look over in recipes?

Good thinking. I'll update the ones for the platform check

@aliciaaevans aliciaaevans merged commit 9f6df10 into master Mar 22, 2024
9 checks passed
@aliciaaevans aliciaaevans deleted the osx-arm-platform branch March 22, 2024 22:36
aliciaaevans added a commit that referenced this pull request Mar 25, 2024
🤖 I have created a release \*beep\* \*boop\*
---
##
[2.13.0](https://www.github.com/bioconda/bioconda-utils/compare/v2.12.0...v2.13.0)
(2024-03-22)


### Features

* add osx-arm64 to platform checks
([#965](https://www.github.com/bioconda/bioconda-utils/issues/965))
([9f6df10](https://www.github.com/bioconda/bioconda-utils/commit/9f6df10bfecd048956acc80e7bb3d57952585529))
---


This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: aliciaaevans <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants