adding in environmental variable to pkg_test#222
adding in environmental variable to pkg_test#222jerowe wants to merge 29 commits intobioconda:masterfrom
Conversation
|
I think it would be best to get it from the command line argument, but I need to sit down and figure out how to do that. |
bioconda_utils/pkg_test.py
Outdated
| logger.debug('Tests to run: %s', tests) | ||
|
|
||
| target = 'biocontainers' | ||
| if os.environ.get('QUAY_TARGET') is not None: |
There was a problem hiding this comment.
Can we call it CONTAINER_NAMESPACE or something?
There was a problem hiding this comment.
We can name it whatever you like . ;-)
|
A proper fix with command line args would be better I agree. But I'm also not opposed to merge this one for the time being. |
|
I can confirm that this works. ;-) |
|
@bgruening , I changed this so that it gets the original command line argument. |
|
@jerowe @bgruening What is the status of this? Do we still need it? |
|
@epruesse , yes, I would still like it. It was the last missing piece of the "let me coopt the bioconda built system to deploy my in house software stacks" puzzle. |
3 participants
@bgruening
Here is a really simple and possibly stupid way to fix the hardcoded biocontainers problem.
Let me know if you think there is a better way to do this.