Skip to content

fix: unexpected arg 'label'#1065

Merged
aliciaaevans merged 2 commits intobioconda:masterfrom
wjunLu:bugfix
Jan 8, 2026
Merged

fix: unexpected arg 'label'#1065
aliciaaevans merged 2 commits intobioconda:masterfrom
wjunLu:bugfix

Conversation

@wjunLu
Copy link
Contributor

@wjunLu wjunLu commented Sep 2, 2025

There is an error in bioconda_utils/cli.py:

Currently, handle_merged_pr calls build with setting arg label, see https://github.com/bioconda/bioconda-utils/blob/41b24166f8e24b2155d4bb2dcfff94c10f46dfb7/bioconda_utils/cli.py#L551C5-L560C10:

if res == UploadResult.NO_ARTIFACTS and fallback == 'build':
        success = build(
            recipe_folder,
            config,
            git_range=git_range,
            anaconda_upload=not dryrun,
            mulled_upload_target=quay_upload_target if not dryrun else None,
            mulled_test=True,
            label=label,
        )

But build is defined as following:

def build(recipe_folder, config, packages="*", git_range=None, testonly=False,
          force=False, docker=None, mulled_test=False, build_script_template=None,
          pkg_dir=None, anaconda_upload=False, mulled_upload_target=None,
          build_image=False, keep_image=False, lint=False, lint_exclude=None,
          check_channels=None, n_workers=1, worker_offset=0, keep_old_work=False,
          mulled_conda_image=pkg_test.MULLED_CONDA_IMAGE,
          docker_base_image=None,
          record_build_failures=False,
          skiplist_leafs=False,
          disable_live_logs=False,
          exclude=None,
          subdag_depth=None):

There is no arg label in build, this will fail when res == UploadResult.NO_ARTIFACTS and fallback == 'build'.

I think maybe it never entered this branch before, so never an error encountered.

Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @wjunLu

@bgruening bgruening requested a review from aliciaaevans January 7, 2026 20:28
@aliciaaevans aliciaaevans merged commit 16f2ab9 into bioconda:master Jan 8, 2026
9 checks passed
bgruening pushed a commit that referenced this pull request Jan 9, 2026
🤖 I have created a release *beep* *boop*
---


##
[3.9.2](v3.9.1...v3.9.2)
(2026-01-09)


### Bug Fixes

* remove deprecated pkg_resources usage ahead of planned removal in
Setuptools ≥81
([#1058](#1058))
([0ef2df1](0ef2df1))
* unexpected arg 'label'
([#1065](#1065))
([16f2ab9](16f2ab9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants