feat: allow and require {{ stdlib("c") }} in recipes#1044
Closed
aliciaaevans wants to merge 3 commits intomasterfrom
Closed
feat: allow and require {{ stdlib("c") }} in recipes#1044aliciaaevans wants to merge 3 commits intomasterfrom
aliciaaevans wants to merge 3 commits intomasterfrom
Conversation
bgruening
reviewed
May 1, 2025
| ``requirements: build:`` section. | ||
| """ | ||
|
|
||
| def check_deps(self, deps): |
Member
There was a problem hiding this comment.
Do we need a check for having stdlib but no compiler?
Contributor
Author
There was a problem hiding this comment.
Good question. It doesn't seem like conda-forge has that check. Although maybe someone might get confused and think they could use it in place of a compiler.
bgruening
approved these changes
May 14, 2025
Contributor
|
@aliciaaevans there are some remaining conflicts. Can you fix them and then merge? |
dlaehnemann
added a commit
to bioconda/bioconda-recipes
that referenced
this pull request
Mar 31, 2026
Originally identified as an issue here: #51185 Similar workaround in: d717ce6 Being resolved in: bioconda/bioconda-utils#1044
Contributor
|
See #1091 |
epruesse
pushed a commit
that referenced
this pull request
Apr 7, 2026
This supersedes #1044. It rebases the original work onto the latest master and resolves conflicts in `bioconductor_skeleton.py` and the linting test suite. It should also maintain author info of previous work by @aliciaaevans. I had left a comment on #1044 saying I didn't have access to push directly to that PR and I also note that Alicia doesn't seem to have had much github activity recently, so thought creating a new PR might be the easiest route to getting this merged? I have been hitting this lint bug (reported in bioconda/bioconda-recipes#51185) a bit recently. Original PR text from #1044: - add stdlib function to JINJA_VARS to prevent the version_constraints_missing_whitespace lint error - add new lint to require stdlib function if compilers are used - update tests for the new lint (and to avoid tripping it when testing other lints) - Add {{ stdlib("c") }} to bioconductor-skeleton See bioconda/bioconda-recipes#51185 From what I can tell, the JINJA_VARS part is used to allow for converting the recipe from string to yaml (which would reject the jinja vars as syntax errors) for various actions by bioconda-utils (such as linting) and not used in the actual build by conda-build. A thorough second look might be a good idea. --------- Co-authored-by: Alicia A. Evans <108547992+aliciaaevans@users.noreply.github.com>
Contributor
Author
|
Thanks, @mbhall88! I haven't had any time lately to keep up with Bioconda, so stepping in to help out is always appreciated. |
Contributor
|
No problem I can totally relate. And thanks for the work on this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JINJA_VARSto prevent theversion_constraints_missing_whitespacelint error{{ stdlib("c") }}to bioconductor-skeletonSee bioconda/bioconda-recipes#51185
From what I can tell, the
JINJA_VARSpart is used to allow for converting the recipe from string to yaml (which would reject the jinja vars as syntax errors) for various actions by bioconda-utils (such as linting) and not used in the actual build by conda-build. A thorough second look might be a good idea.