Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lovis4u added #52590

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

lovis4u added #52590

wants to merge 1 commit into from

Conversation

art-egorov
Copy link

@art-egorov art-egorov commented Dec 4, 2024

Describe your pull request here

Adding lovis4u tool to the bioconda:
https://github.com/art-egorov/lovis4u


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@apcamargo
Copy link
Contributor

Is there any reason you didn't include MMseqs2 as a dependency?

@art-egorov
Copy link
Author

@apcamargo
I want to keep pypi version as primary allowing to run lovis4u without additional installation of non-python dependencies like mmseqs. Already built mmseqs for mac and linux embedded in the library by default. (And for conda I want to set up just autoupdate from pypi version).
However, a user can change the mmseqs path to their own mmseqs in config files if it's needed.

@apcamargo
Copy link
Contributor

Humnn, ok. I understand why you'd do that for a PyPI distribution, but for Conda this is not ideal (for instance, you package can't be noarch because of that). Bioconda also disencourages pre-compiled binaries. Maybe we could apply a patch to remove the bundled MMseqs2, but I'd prefer to get the opinion from someone from @bioconda/core first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants