Skip to content

Conversation

@martin-g
Copy link
Member

@martin-g martin-g commented Dec 3, 2024

Describe your pull request here


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@martin-g martin-g added the aarch64 Related to adding linux-aarch64 support label Dec 3, 2024
@martin-g
Copy link
Member Author

martin-g commented Dec 3, 2024

The ARM64 build fails due to:

13:01:24 BIOCONDA INFO (OUT) The following packages are incompatible
13:01:24 BIOCONDA INFO (OUT) ├─ circos is not installable because it requires
13:01:24 BIOCONDA INFO (OUT) │  └─ perl-gd, which does not exist (perhaps a missing channel);
13:01:24 BIOCONDA INFO (OUT) ├─ minimap2 >=2.10  is installable and it requires
13:01:24 BIOCONDA INFO (OUT) │  └─ k8 with the potential options
13:01:24 BIOCONDA INFO (OUT) │     ├─ k8 [1.0|1.2] would require
13:01:24 BIOCONDA INFO (OUT) │     │  └─ python_abi 3.8.* *_cp38, which can be installed;
13:01:24 BIOCONDA INFO (OUT) │     └─ k8 1.2 would require
13:01:24 BIOCONDA INFO (OUT) │        └─ python_abi 3.12.* *_cp312, which can be installed;
13:01:24 BIOCONDA INFO (OUT) └─ python 3.10.* *_cpython is not installable because it requires
13:01:24 BIOCONDA INFO (OUT)    └─ python_abi 3.10.* *_cp310, which conflicts with any installable versions previously reported.

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@dslarm
Copy link
Contributor

dslarm commented Feb 4, 2025

with a rebase today we get:

├─ circos is not installable because it requires
│  └─ perl-params-validate, which does not exist (perhaps a missing channel);
├─ minimap2 >=2.10  is installable and it requires
│  └─ k8 with the potential options
│     ├─ k8 [1.0|1.2] would require
│     │  └─ python_abi 3.8.* *_cp38, which can be installed;
│     ├─ k8 1.2 would require
│     │  └─ python_abi 3.13.* *_cp313, which can be installed;
│     └─ k8 1.2 would require
│        └─ python_abi 3.12.* *_cp312, which can be installed;
└─ python 3.10.* *_cpython is not installable because it requires
   └─ python_abi 3.10.* *_cp310, which conflicts with any installable versions previously reported.

@dslarm
Copy link
Contributor

dslarm commented Feb 5, 2025

#53705 will help - perl-params-validate (cropped up for me in hmftools-linx)

@dslarm
Copy link
Contributor

dslarm commented Feb 5, 2025

This @martin-g @mencian - the dependency is done - this can be rerun.

@dslarm
Copy link
Contributor

dslarm commented Feb 5, 2025

@BiocondaBot rebuild

@martin-g
Copy link
Member Author

martin-g commented Feb 5, 2025

@BiocondaBot please fetch artifacts

@BiocondaBot
Copy link
Collaborator

Package(s) built are ready for inspection:

Arch Package Zip File / Repodata CI Instructions
linux-64 quast-5.3.0-py313pl5321h5ca1c30_2.tar.bz2 linux-64.zip GitHub Actions
showYou may also use conda to install after downloading and extracting the zip file. conda install -c ./packages <package name>
linux-aarch64 quast-5.3.0-py313pl5321h0aa3852_2.tar.bz2 repodata.json CircleCI
showYou may also use conda to install:conda install -c https://output.circle-artifacts.com/output/job/7ad483ce-eea9-456b-aaee-de9f5d460307/artifacts/0/tmp/artifacts/packages <package name>

Docker image(s) built:

Package Tag CI Install with docker
quast 5.3.0--py313pl5321h5ca1c30_2 GitHub Actions
showImages are in the linux-64 zip file above.gzip -dc images/quast---5.3.0--py313pl5321h5ca1c30_2.tar.gz | docker load

@martin-g
Copy link
Member Author

martin-g commented Feb 5, 2025

@BiocondaBot please fetch artifacts

@BiocondaBot
Copy link
Collaborator

Package(s) built are ready for inspection:

Arch Package Zip File / Repodata CI Instructions
linux-64 quast-5.3.0-py313pl5321h5ca1c30_2.tar.bz2 linux-64.zip GitHub Actions
showYou may also use conda to install after downloading and extracting the zip file. conda install -c ./packages <package name>
osx-64 quast-5.3.0-py313pl5321h1f6ca2e_2.tar.bz2 osx-64.zip GitHub Actions
showYou may also use conda to install after downloading and extracting the zip file. conda install -c ./packages <package name>
linux-aarch64 quast-5.3.0-py313pl5321h0aa3852_2.tar.bz2 repodata.json CircleCI
showYou may also use conda to install:conda install -c https://output.circle-artifacts.com/output/job/05b23bbe-5281-4227-abce-8cc12467be66/artifacts/0/tmp/artifacts/packages <package name>

Docker image(s) built:

Package Tag CI Install with docker
quast 5.3.0--py313pl5321h5ca1c30_2 GitHub Actions
showImages are in the linux-64 zip file above.gzip -dc images/quast---5.3.0--py313pl5321h5ca1c30_2.tar.gz | docker load

@martin-g
Copy link
Member Author

martin-g commented Feb 5, 2025

@dslarm @mencian What do you think about this solution ?

@martin-g
Copy link
Member Author

martin-g commented Feb 5, 2025

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Feb 5, 2025
@dslarm
Copy link
Contributor

dslarm commented Feb 5, 2025

LGTM!

@martin-g martin-g requested a review from mencian February 12, 2025 19:31
@mencian mencian merged commit a5aefad into bioconda:master Feb 19, 2025
5 checks passed
@martin-g martin-g deleted the aarch64-quast branch February 19, 2025 09:20
Hugovdberg pushed a commit to Hugovdberg/bioconda-recipes that referenced this pull request Mar 1, 2025
* quast: add linux-aarch64 build

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>

* Update meta.yaml

* Update build.sh

* Update meta.yaml

* Try with Python 3.12+

* Use Python 3.12+ only for aarch64

* Python 3.12+ for all. linux-64 tests failed

---------

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Co-authored-by: Joshua Zhuang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aarch64 Related to adding linux-aarch64 support please review & merge set to ask for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants