-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add genodsp #51488
Add genodsp #51488
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThis pull request introduces two new files related to the Possibly related PRs
Suggested labels
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used🔇 Additional comments (7)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🧹 Outside diff range and nitpick comments (4)
recipes/genodsp/build.sh (1)
6-6
: LGTM: Efficient build command with room for minor improvement.The
make
command is well-constructed:
VERBOSE=1
enables detailed output, which is helpful for debugging.-j ${CPU_COUNT}
enables parallel building, optimizing the build process.Consider adding error handling for the make command. For example:
-make VERBOSE=1 -j ${CPU_COUNT} +if ! make VERBOSE=1 -j ${CPU_COUNT}; then + echo "Build failed" >&2 + exit 1 +fiThis change will provide a more informative error message if the build fails.
recipes/genodsp/meta.yaml (2)
25-29
: Consider enhancing test coverage.The current test commands verify the basic installation and help functionality. To ensure robust package quality, consider adding more comprehensive tests.
Suggestions for additional tests:
- Verify specific features or commands of genodsp.
- Test with a small sample dataset, if applicable.
- Check for expected output files or formats.
Example of an additional test command:
- genodsp --version # Verify version information
31-35
: Consider adding more metadata.The about section provides essential information, but could be enhanced with additional details to improve discoverability and user understanding.
Consider adding:
dev_url
pointing to the GitHub repository for development-related information.doc_url
if separate documentation exists.description
with a more detailed explanation of the tool's functionality.Example additions:
dev_url: https://github.com/rsharris/genodsp description: | genodsp is a general workbench for processing signals along genomic (chromosomal) intervals. It provides tools for [specific functionalities, if known].recipes/genodsp/stringop-truncation.patch (1)
1-167
: Overall assessment: Consider a more comprehensive approach to string handlingThis patch consistently applies warning suppression for
strncpy
across multiple files and functions. While this addresses the immediate compilation warnings, it doesn't resolve the underlying issues. Here's a summary of the situation and recommendations:
- Consistency: The patch is consistently applied, which is good for maintainability.
- Localization: The warning suppression is properly localized to specific
strncpy
calls.- Underlying issues: The root cause of potential string truncation remains unaddressed.
Recommendations:
- Implement a safe string copying helper function as suggested in the
minmax.c
review comment.- Review the overall design to potentially eliminate the need for these string copy operations.
- If possible, increase the size of the
prevChrom
buffer to accommodate longer strings.- Consider using more robust string handling functions like
snprintf
instead ofstrncpy
.Next steps:
- Implement and test the helper function approach in one file.
- If successful, apply this approach across all affected files.
- Add comments explaining the rationale behind this approach and any known limitations.
Would you like assistance in implementing a safe string copying helper function or in refactoring one of the affected functions as a proof of concept?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (3)
- recipes/genodsp/build.sh (1 hunks)
- recipes/genodsp/meta.yaml (1 hunks)
- recipes/genodsp/stringop-truncation.patch (1 hunks)
🧰 Additional context used
🪛 Shellcheck
recipes/genodsp/build.sh
[error] 9-9: Couldn't parse this double quoted string. Fix to allow more checks.
(SC1073)
🪛 yamllint
recipes/genodsp/meta.yaml
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
🔇 Additional comments (10)
recipes/genodsp/build.sh (2)
1-2
: LGTM: Robust script setup.The script starts with good practices for error handling and debugging:
- Using
#!/bin/bash -e
ensures the script exits on any error.set -uex
further enhances error handling and provides verbose execution, which is helpful for debugging build issues.
4-4
: LGTM: Proper directory creation.The
mkdir
command is used correctly with the-vp
flags, ensuring the binary directory is created (or exists) without errors. The use of${PREFIX}
is consistent with common build environment practices.recipes/genodsp/meta.yaml (3)
19-23
: Build configuration looks good.The build section is well-configured:
- Correctly skips build for unsupported platforms.
- Uses
run_exports
to ensure ABI compatibility.- Properly pins the subpackage version.
These practices help maintain consistency and compatibility across the Conda ecosystem.
8-12
: Verify the necessity and content of the patch file.The recipe includes a patch file
stringop-truncation.patch
. While patches are sometimes necessary, they can also indicate upstream issues that should be addressed.Please ensure that:
- The patch is necessary and cannot be avoided by updating the upstream source.
- The patch has been submitted upstream or there's a plan to do so.
To review the content of the patch file, run:
#!/bin/bash # Display the content of the patch file cat recipes/genodsp/stringop-truncation.patch
1-6
: Consider revising the version number format.The version number "0.0.3+" includes a "+" character, which is unusual in semantic versioning. This might cause issues with version comparisons in package management systems.
Consider changing it to a standard format like "0.0.3" or "0.0.3.0". If the "+" has a specific meaning in your versioning scheme, please clarify its purpose.
To check if this version format is used consistently across the project, run:
✅ Verification successful
Version number format confirmed.
The version number "0.0.3+" is uniquely used in
recipes/genodsp/meta.yaml
. If the "+" serves a specific purpose in your versioning scheme, please ensure it's handled correctly by your package management system. Otherwise, consider updating it to a standard format like "0.0.3" to maintain consistency and prevent potential issues.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for version strings in the repository rg -i 'version.*0\.0\.3\+' --type yamlLength of output: 5215
🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
recipes/genodsp/stringop-truncation.patch (5)
27-41
: Consistent application of warning suppressionThe changes in
genodsp.c
are identical to those inadd.c
. While consistency is good for maintainability, the same considerations about warning suppression apply here. Please refer to the previous comment for detailed suggestions and alternatives.
42-68
: Consistent warning suppression in logical operationsThe changes in
logical.c
follow the same pattern as in previous files, applying warning suppression to two different functions. The consistency is commendable, but the concerns raised in the first comment about warning suppression remain valid here.
69-94
: Consistent warning suppression in masking operationsThe changes in
mask.c
continue the pattern seen in previous files, applying warning suppression to two different functions. While the consistency is good, the concerns about warning suppression raised in the first comment are still applicable.
142-167
: Consistent warning suppression in multiplication operationsThe changes in
multiply.c
continue the pattern seen in previous files, applying warning suppression to two different functions. While the consistency is maintained, the concerns and suggestions raised in previous comments, particularly the recommendation for a helper function in theminmax.c
review, are applicable here as well.
1-26
:⚠️ Potential issueConsider alternative approaches to warning suppression
The patch introduces compiler directives to suppress the "-Wstringop-truncation" warning for
strncpy
calls. While this addresses the immediate compilation warnings, it may hide potential issues:
- Suppressing warnings can mask real problems that might lead to buffer overflows or truncated data.
- The code's behavior remains unchanged, potentially leaving underlying issues unresolved.
Consider these alternatives:
- Use
snprintf
instead ofstrncpy
to ensure null-termination and avoid truncation.- If
strncpy
must be used, add explicit null-termination after the call.- Increase the size of
prevChrom
if possible to accommodate longer strings.Example using
snprintf
:snprintf(prevChrom, sizeof(prevChrom), "%s", chrom);If you decide to keep the current approach, add a comment explaining why the warning suppression is necessary and that the code has been reviewed for safety.
To ensure this change is appropriate, let's verify the usage of
prevChrom
:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
recipes/genodsp/stringop-truncation.patch (1)
142-172
: LGTM: Implementation of safe_strncpy, but consider ensuring null-terminationThe implementation of
safe_strncpy
inutilities.c
and its declaration inutilities.h
are correct and address the string truncation warnings effectively.However, I noticed that the line ensuring null-termination is commented out:
//dest[n-1] = '\0'; // Ensure null-termination
Consider uncommenting this line to ensure that the destination string is always null-terminated. This adds an extra layer of safety, especially in cases where the source string might be exactly
n
characters long.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
- recipes/genodsp/build.sh (1 hunks)
- recipes/genodsp/stringop-truncation.patch (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- recipes/genodsp/build.sh
🧰 Additional context used
🔇 Additional comments (7)
recipes/genodsp/stringop-truncation.patch (7)
1-23
: LGTM: Consistent use of safe_strncpy in add.cThe changes in
add.c
correctly replacestrncpy
withsafe_strncpy
, addressing potential string truncation warnings without altering the underlying logic. This is consistent with the overall goal of the patch.
24-35
: LGTM: Consistent use of safe_strncpy in genodsp.cThe change in
genodsp.c
correctly replacesstrncpy
withsafe_strncpy
, maintaining consistency with the changes in other files and addressing potential string truncation warnings.
36-58
: LGTM: Consistent use of safe_strncpy in logical.cThe changes in
logical.c
correctly replacestrncpy
withsafe_strncpy
in two instances, maintaining consistency with the changes in other files and addressing potential string truncation warnings.
59-80
: LGTM: Consistent use of safe_strncpy in mask.cThe changes in
mask.c
correctly replacestrncpy
withsafe_strncpy
in two instances, maintaining consistency with the changes in other files and addressing potential string truncation warnings.
81-119
: LGTM: Consistent use of safe_strncpy in minmax.c, but consider further improvementsThe changes in
minmax.c
correctly replacestrncpy
withsafe_strncpy
in four instances, maintaining consistency with the changes in other files and addressing potential string truncation warnings.However, I'd like to reiterate a point from a previous review:
Given the frequency of this pattern in
minmax.c
, consider:
- Implementing a helper function that safely copies strings and is used across all these functions.
- Reviewing the overall design of these functions to see if there's a way to avoid the need for string copying altogether.
While the current changes address the immediate issue, a more comprehensive solution could further improve code quality and maintainability.
120-141
: LGTM: Consistent use of safe_strncpy in multiply.cThe changes in
multiply.c
correctly replacestrncpy
withsafe_strncpy
in two instances, maintaining consistency with the changes in other files and addressing potential string truncation warnings.
1-172
: Overall assessment: Effective solution with room for further improvementThis patch successfully addresses string truncation warnings by introducing and consistently using a
safe_strncpy
function across multiple files. The implementation effectively suppresses the warnings without altering the core logic of the affected functions.Key points:
- The changes are consistent and well-applied across all modified files.
- The
safe_strncpy
function is correctly implemented and declared.Suggestions for further improvement:
- Consider uncommenting the null-termination line in
safe_strncpy
for added safety.- For
minmax.c
, explore the possibility of a more comprehensive solution to reduce code duplication and improve maintainability.Overall, this patch is a solid step towards improving the code quality and addressing compiler warnings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (3)
recipes/genodsp/meta.yaml (2)
8-12
: Document the purpose of the patch file.The recipe includes a patch file
stringop-truncation.patch
. It's a good practice to document the purpose of patch files in the recipe.Consider adding a comment explaining the purpose of the
stringop-truncation.patch
file. For example:patches: # Fix compiler warnings related to string truncation - stringop-truncation.patch
32-36
: Add maintainer information to the recipe.The about section provides good metadata about the package. To further improve it, consider adding maintainer information.
Add a
maintainers
field to theabout
section:about: home: https://github.com/rsharris/genodsp summary: General workbench for processing signals along genomic (chromosomal) intervals license: GPL-3.0-only license_url: https://github.com/rsharris/genodsp/blob/master/LICENSE maintainers: - your_github_usernameReplace
your_github_username
with the appropriate maintainer information.recipes/genodsp/stringop-truncation.patch (1)
150-159
: LGTM! Consider adding a size check for robustness.The implementation of
safe_strncpy
effectively addresses the string truncation warning while ensuring proper null-termination. This is a good practice for safer string handling.For additional robustness, consider adding a size check to ensure
n
is greater than 0:void safe_strncpy(char *dest, const char *src, size_t n) { if (n == 0) return; #pragma GCC diagnostic push #pragma GCC diagnostic ignored "-Wstringop-truncation" strncpy(dest, src, n); #pragma GCC diagnostic pop dest[n-1] = '\0'; // Ensure null-termination }This prevents potential undefined behavior if
n
is 0.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
- recipes/genodsp/meta.yaml (1 hunks)
- recipes/genodsp/stringop-truncation.patch (1 hunks)
🧰 Additional context used
🪛 yamllint
recipes/genodsp/meta.yaml
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
🔇 Additional comments (6)
recipes/genodsp/meta.yaml (3)
1-6
: Verify the package version.The version is set to "0.0.3+". The "+" might indicate a post-release or development version. Consider using a more specific version number if this is not intentional.
Please confirm if "0.0.3+" is the correct version or if it should be updated to a more specific release version.
🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
20-24
: Verify and document platform limitations.The recipe is set to skip building on non-Linux and non-x86_64 platforms. While this might be intentional, it limits the package's availability.
Please confirm if this limitation is necessary. If so, consider adding a comment explaining why:
build: number: 0 # genodsp is currently only supported on Linux x86_64 due to [reason] skip: True # [not linux or not x86_64]If possible, consider expanding support to other platforms in the future.
14-18
:⚠️ Potential issueAdd runtime dependencies to the recipe.
The recipe specifies build requirements but lacks run requirements. Based on the nature of the package (a C program for genomic signal processing), it likely has runtime dependencies.
Please add a
run
section underrequirements
and include necessary runtime dependencies. For example:requirements: build: - {{ compiler('c') }} - {{ stdlib('c') }} - make run: - {{ stdlib('c') }} # Add other runtime dependencies hereIf there are no additional runtime dependencies, it's good practice to explicitly state this in a comment.
recipes/genodsp/stringop-truncation.patch (3)
1-141
: LGTM! Consistent usage ofsafe_strncpy
across files.The replacement of
strncpy
withsafe_strncpy
is consistently applied across all affected files (add.c, genodsp.c, logical.c, mask.c, minmax.c, multiply.c). This systematic approach ensures code consistency and improves safety throughout the codebase.
168-169
: LGTM! Proper declaration ofsafe_strncpy
in utilities.h.The declaration of
safe_strncpy
in the header file is correct and consistent with its implementation. This allows other parts of the codebase to use the new function, promoting code reuse and maintainability.
1-172
: Current implementation supersedes previous suggestion.The implemented solution of introducing
safe_strncpy
and using it consistently across all files is more comprehensive and maintainable than the previously suggested approach of creating a helper function specifically for minmax operations.This general solution:
- Addresses the string truncation warning across the entire codebase, not just in minmax.c.
- Promotes code reuse and consistency.
- Centralizes the warning suppression in a single, well-defined function.
@bioconda/core Please advise. It looks like I'm triggering the version_constraints_missing_whitespace check: https://dev.azure.com/bioconda/bioconda-recipes/_build/results?buildId=72098&view=logs&j=eb1ca712-fec5-5d93-deb0-40983fe61f2f&t=c9ebc308-e058-58af-a4f4-866fa7649dbb |
@richard-burhans There's a problem with the linter and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
recipes/genodsp/meta.yaml (2)
1-6
: Consider clarifying the version number format.The version number "0.0.3+" uses a "+" sign, which is not a standard part of semantic versioning. This might cause issues with package management systems. Consider using a more conventional version number format (e.g., "0.0.3" or "0.0.3.0") unless there's a specific reason for this notation.
🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
25-29
: Consider adding more comprehensive test commands.While the current test commands check for basic functionality, consider adding more specific test cases that validate the core features of
genodsp
. For example:
- Test processing a small sample genomic interval
- Verify output format correctness
- Check handling of edge cases or specific input types
This will help ensure that the package is functioning as expected after installation.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/genodsp/meta.yaml (1 hunks)
🧰 Additional context used
🪛 yamllint
recipes/genodsp/meta.yaml
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
🔇 Additional comments (3)
recipes/genodsp/meta.yaml (3)
14-17
: Add runtime dependencies to the recipe.The build requirements are specified, but runtime dependencies are missing. As mentioned in a previous review, the analysis of the source code reveals dependencies on standard C++ libraries and possibly a custom library (
BamBam_SamBamFileDecoder
).Consider adding the following to the
requirements
section:
run:
{{ pin_compatible('glibc', max_pin='x.x') }}
bambamc
(if available as a package)- Any other identified libraries
This ensures that the package will function correctly at runtime.
1-1
: Ignore yamllint false positive.The yamllint tool reports a syntax error for the '%' character at the beginning of the file. This is a false positive as the '%' is part of the valid Jinja2 templating syntax used in Conda recipe files. No action is required to address this warning.
🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
8-12
: Verify the patch file existence and content.The meta.yaml file references a patch file named "stringop-truncation.patch". Please ensure that this file exists in the recipe directory and that its content addresses the intended issue.
✅ Verification successful
Patch file verified and addresses string operation truncation concerns.
The patch file "stringop-truncation.patch" exists in the recipe directory and correctly replaces
strncpy
withsafe_strncpy
across relevant source files. Additionally, thesafe_strncpy
function is properly defined inutilities.c
and declared inutilities.h
, ensuring safe string operations with null-termination.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if the patch file exists and display its content if [ -f recipes/genodsp/stringop-truncation.patch ]; then echo "Patch file exists. Content:" cat recipes/genodsp/stringop-truncation.patch else echo "Patch file does not exist in the expected location." fiLength of output: 5420
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/genodsp/meta.yaml (1 hunks)
🧰 Additional context used
🪛 yamllint
recipes/genodsp/meta.yaml
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
🔇 Additional comments (7)
recipes/genodsp/meta.yaml (7)
1-6
: LGTM: Package section is well-defined.The package name and version are correctly defined using Jinja2 variables. The use of
{{ name|lower }}
ensures the package name is lowercase, which is a good practice.🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
11-12
: Provide information about the patch file.A patch file
stringop-truncation.patch
is specified. Could you provide more information about what this patch addresses? It would be helpful to include a brief comment explaining the purpose of the patch.
14-17
: Add run requirements to the recipe.The recipe specifies build requirements but lacks run requirements. Based on the previous analysis of the source code, consider adding the following to the
requirements
section:requirements: build: - {{ compiler('c') }} - make run: - {{ pin_compatible('glibc', max_pin='x.x') }} - bambamc # if available as a packageThis ensures that the necessary runtime dependencies are available when the package is installed.
19-23
: Verify and document the platform limitation.The recipe is currently limited to Linux x86_64 platforms. If this limitation is intentional, please add a comment explaining why. If not, consider removing or adjusting the skip condition to support more platforms:
build: number: 0 skip: True # [not linux or not x86_64] # Add a comment here explaining the reason for the platform limitation run_exports: - {{ pin_subpackage('genodsp', max_pin="x.x") }}
25-29
: LGTM: Test section is well-defined.The test commands are comprehensive, checking both the presence of the binary and its basic functionality. The use of both relative and absolute paths for the binary ensures thorough testing.
31-36
: LGTM: About section is complete and accurate.The about section provides all necessary metadata, including the home URL, a concise summary, and correct license information. The inclusion of both
license_file
andlicense_url
is a good practice for ensuring license visibility.
1-2
: Note on static analysis warning.The yamllint tool reported a syntax error for the '%' character at the beginning of the file. This is a false positive, as the '%' is part of the valid Jinja2 templating syntax used in conda recipes. No action is required to address this warning.
🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
version: {{ version }} | ||
|
||
source: | ||
url: https://github.com/rsharris/genodsp/archive/refs/tags/v{{ version }}+.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the '+' from the source URL.
The '+' in the URL might cause issues when fetching the source. Consider removing it:
url: https://github.com/rsharris/genodsp/archive/refs/tags/v{{ version }}.zip
@richard-burhans I have now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/genodsp/stringop-truncation.patch (1 hunks)
🧰 Additional context used
🔇 Additional comments (8)
recipes/genodsp/stringop-truncation.patch (8)
7-7
: Approved: Removal of hardcoded compiler assignmentThe removal of
CC = gcc
allows the build process to use the compiler specified in the environment, enhancing portability and flexibility.
20-20
: Approved: Use ofsafe_strncpy
inadd.c
Replacing
strncpy
withsafe_strncpy
improves string handling by ensuring proper null-termination and suppressing warnings about string truncation.Also applies to: 29-29
42-42
: Approved: Use ofsafe_strncpy
ingenodsp.c
Replacing
strncpy
withsafe_strncpy
enhances the safety of string operations in this file.
55-55
: Approved: Use ofsafe_strncpy
inlogical.c
Consistently using
safe_strncpy
improves string safety across the codebase.Also applies to: 64-64
77-77
: Approved: Use ofsafe_strncpy
inmask.c
The changes enhance string operation safety by ensuring proper null-termination.
Also applies to: 86-86
99-99
: Approved: Use ofsafe_strncpy
inminmax.c
Updating to
safe_strncpy
improves string handling safety in multiple functions within this file.Also applies to: 108-108, 117-117, 126-126
139-139
: Approved: Use ofsafe_strncpy
inmultiply.c
The replacement ensures safer string operations and consistency.
Also applies to: 148-148
178-178
: Approved: Declaration ofsafe_strncpy
inutilities.h
Adding the function declaration ensures that
safe_strncpy
is accessible across multiple source files.
@BiocondaBot please add label |
Adding genodsp -- General workbench for processing signals along genomic intervals
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add label
command.@bioconda/core
in a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports
(see here for the rationale and comprehensive explanation).Add a
run_exports
section like this:with
...
being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}
while replacing
"myrecipe"
with eithername
if aname|lower
variable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update
@BiocondaBot please add label
please review & merge
label.@BiocondaBot please fetch artifacts
You can use this to test packages locally.
Note that the
@BiocondaBot please merge
command is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>
and will automatically re-post them to notify the addressed<team>
.