Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add r-saccharis #51468

Open
wants to merge 36 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 28 commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
cb93e7e
Add recipe for saccharis 2.0 dev18 build 1 to bioconda
AlexSCFraser Jun 13, 2023
f6f773d
updated to use git tag
AlexSCFraser Jun 23, 2023
e647f0b
Merge branch 'master' into saccharis
AlexSCFraser Jun 23, 2023
d37cc1b
updated to use a python package generated from setuptools build, with…
AlexSCFraser Jun 23, 2023
25078ad
Merge remote-tracking branch 'origin/saccharis' into saccharis
AlexSCFraser Jun 23, 2023
ae1285b
lowercased hash, since it's case-sensitive
AlexSCFraser Jun 24, 2023
a7ddfe6
added filename as "fn: saccharis-{{ version }}.tar.gz"
AlexSCFraser Jun 24, 2023
ebbdbc4
removed filename since bioconda considers it an error
AlexSCFraser Jun 24, 2023
3e3a965
update url link
AlexSCFraser Jun 24, 2023
4696ace
update sha256
AlexSCFraser Jun 24, 2023
e68ac62
remove unneeded comments
AlexSCFraser Jun 26, 2023
a5b62b4
remove tests which write files
AlexSCFraser Jun 26, 2023
f2ff867
remove tests which write files, with comment
AlexSCFraser Jun 26, 2023
675e10e
Merge branch 'master' into saccharis
AlexSCFraser Jun 26, 2023
9ce1b21
Merge branch 'saccharis' of https://github.com/saccharis/bioconda-rec…
AlexSCFraser Jun 26, 2023
83b518b
add new release data to bioconda recipe
AlexSCFraser Aug 23, 2023
93dc1ee
Merge branch 'master' into saccharis
AlexSCFraser Aug 23, 2023
7e31b96
change build number to zero to satisfy bioconda linter
AlexSCFraser Aug 24, 2023
a383bb2
Merge remote-tracking branch 'origin/saccharis' into saccharis
AlexSCFraser Aug 24, 2023
68d2dec
Merge branch 'master' into saccharis
AlexSCFraser Aug 24, 2023
9ab5ebd
add blast dependency
AlexSCFraser Aug 29, 2023
12f9814
Merge remote-tracking branch 'origin/saccharis' into saccharis
AlexSCFraser Aug 29, 2023
678ec9e
Merge branch 'master' into saccharis
AlexSCFraser Aug 29, 2023
84a1857
add run_exports breaking change behaviour
AlexSCFraser Aug 29, 2023
e8bbcb9
Merge branch 'master' of https://github.com/bioconda/bioconda-recipes
AlexSCFraser Oct 17, 2024
ccce12d
add r-saccharis package to bioconda-recipes
AlexSCFraser Oct 17, 2024
d5b5f11
add run_exports to r-saccharis
AlexSCFraser Oct 17, 2024
cfc4f4e
Merge branch 'master' into rsaccharis
AlexSCFraser Oct 17, 2024
cebb1b2
fix meta.yaml brackets
AlexSCFraser Oct 17, 2024
ff358fe
Merge remote-tracking branch 'origin/rsaccharis' into rsaccharis
AlexSCFraser Oct 17, 2024
b62d03e
remove numpy spec
AlexSCFraser Oct 18, 2024
c9f6de1
Merge branch 'master' into rsaccharis
AlexSCFraser Oct 18, 2024
07d93d6
update licence identifier
AlexSCFraser Oct 18, 2024
cb3324a
Merge remote-tracking branch 'origin/rsaccharis' into rsaccharis
AlexSCFraser Oct 18, 2024
938cd94
try commenting out magicfor from host because build server doesn't ha…
AlexSCFraser Oct 18, 2024
8d253b5
add pre-link.sh to add r channel
AlexSCFraser Oct 18, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions recipes/r-saccharis/build.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
#!/bin/bash
$R CMD INSTALL --build .
5 changes: 5 additions & 0 deletions recipes/r-saccharis/conda_build_config.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
numpy:
- 1.17

r_base:
- 3.6.3
63 changes: 63 additions & 0 deletions recipes/r-saccharis/meta.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
{% set version = "1.0.4" %}
{% set name = "r-saccharis" %}
{% set build_number = 0%}
{% set filehash = "F02EC69008F688440D7D4230751D1A8C9501F24F2382F399317591C4005DF19F"%}

package:
name: '{{ name|lower }}'
version: '{{ version }}'

source:
url:
- 'https://github.com/saccharis/rsaccharis/releases/download/{{ version }}/rsaccharis_{{ version }}.tar.gz'
sha256: {{ filehash|lower}}

build:
noarch: generic
number: {{ build_number }}
rpaths:
- lib/R/lib/
- lib/
run_exports:
- { { pin_subpackage("r-saccharis", max_pin="x.x") } }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Build configuration looks good, but needs a minor fix.

The build configuration is well-structured with appropriate settings for an R package. However, there's a syntax issue in the run_exports section.

Fix the spacing in the run_exports section. Apply this diff:

-    - { { pin_subpackage("r-saccharis", max_pin="x.x") } }
+    - {{ pin_subpackage("r-saccharis", max_pin="x.x") }}

This removes the extra spaces within the Jinja2 brackets, which would cause a syntax error during package building.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
build:
noarch: generic
number: {{ build_number }}
rpaths:
- lib/R/lib/
- lib/
run_exports:
- { { pin_subpackage("r-saccharis", max_pin="x.x") } }
build:
noarch: generic
number: {{ build_number }}
rpaths:
- lib/R/lib/
- lib/
run_exports:
- {{ pin_subpackage("r-saccharis", max_pin="x.x") }}


requirements:
host:
- r-base
- r-jsonlite
- r-ape
- r-stringr
- r-magicfor
- r-knitr
- r-dplyr
- r-magrittr
- r-rcolorbrewer
- r-ggnewscale
- r-ggplot2
- bioconductor-ggtree
run:
- r-base
- r-jsonlite
- r-ape
- r-stringr
- r-magicfor
- r-knitr
- r-dplyr
- r-magrittr
- r-rcolorbrewer
- r-ggnewscale
- r-ggplot2
- bioconductor-ggtree

test:
commands:
- 'Rscript -e "library(rsaccharis)"'

about:
home: 'https://github.com/saccharis/rsaccharis'
license: 'GPL 3'
summary: 'A rendering package for creating phylogenetic trees from SACCHARIS .json and .tree files, in the R statistical computing language.'
description: 'This package will use metadata .json and .tree files output from SACCHARIS v2 to generate annotated phylogenetic tree PDF files.
Highly customizable, as the formatting of the tree is done using ggplot2. Of course plotting functions can easily be manipulated as desired.
To use, call A_load_data() and B_plots_all() and follow prompts. Our default plots used for publication are domain_ECno_numeric.'
license_file: LICENSE.md
Loading