Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rna-seqc python utilities and qtl package #51344

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add rna-seqc python utilities and qtl package #51344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d6b2f35
enh: Add rna-seqc python utilities and qtl package
lrvdijk Oct 11, 2024
324d35f
fix: Include home, license and run_exports
lrvdijk Oct 11, 2024
01655f1
fix: Fix incorrect package name in qtl
lrvdijk Oct 11, 2024
624351d
fix: Template variable name in rna-seqc-python
lrvdijk Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 49 additions & 0 deletions recipes/qtl/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
{% set name = "qtl" %}
{% set version = "0.1.8" %}

package:
name: {{ name|lower }}
version: {{ version }}

source:
url: https://pypi.org/packages/source/{{ name[0] }}/{{ name }}/qtl-{{ version }}.tar.gz
sha256: 8fdb99cda1ceff578a233db6c15a944fa57b43a2826af41c292e36848906117b

build:
noarch: python
script: {{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation
number: 0
run_exports:
- {{ pin_subpackage("qtl", max_pin="x.x") }}
Comment on lines +12 to +17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Consider removing the run_exports section.

The build configuration looks good overall:

  • noarch: python is correctly set for a pure Python package.
  • The pip install script uses the recommended flags for Conda builds.

However, the run_exports section is unusual for a Python package and may not be necessary. Unless there's a specific reason for pinning the qtl package version in downstream dependencies, consider removing this section to simplify the build configuration.

If you decide to keep the run_exports section, please add a comment explaining why this pinning is required. Otherwise, you can remove it by applying this diff:

 build:
   noarch: python
   script: {{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation
   number: 0
-  run_exports:
-    - {{ pin_subpackage("qtl", max_pin="x.x") }}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
build:
noarch: python
script: {{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation
number: 0
run_exports:
- {{ pin_subpackage("qtl", max_pin="x.x") }}
build:
noarch: python
script: {{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation
number: 0


requirements:
host:
- python
- pip
run:
- python
- numpy
- pandas
- scipy
- matplotlib-base
- seaborn
- pybigwig
- bx-python

test:
imports:
- qtl
commands:
- pip check
requires:
- pip

about:
home: https://github.com/broadinstitute/pyqtl
summary: Utilities for analyzing and visualizing QTL data
license: BSD-3-Clause
license_file: LICENSE

extra:
recipe-maintainers:
- lrvdijk
48 changes: 48 additions & 0 deletions recipes/rna-seqc-python/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
{% set pypi_name = "rnaseqc" %}
{% set version = "0.0.3" %}

package:
name: "rna-seqc-python"
version: {{ version }}

source:
url: https://pypi.org/packages/source/{{ pypi_name[0] }}/{{ pypi_name }}/rnaseqc-{{ version }}.tar.gz
sha256: 857ad1ad54f2b563163d75ff8c5f2439208d06980b7c8ded279bd59d19c48a0f

build:
noarch: python
script: {{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation
number: 0
run_exports:
- {{ pin_subpackage("rna-seqc-python", max_pin="x.x") }}

requirements:
host:
- python
- pip
run:
- python
- numpy
- pandas
- matplotlib-base
- seaborn
- qtl
- nbformat

test:
imports:
- rnaseqc
commands:
- pip check
requires:
- pip

about:
home: https://github.com/broadinstitute/rnaseqc
summary: Multi-sample visualization of metrics from RNA-SeQC
license: BSD 3-clause
license_family: BSD

extra:
recipe-maintainers:
- lrvdijk
Loading