Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pathogen-embed: Use predictable url that autobump can use #49243

Merged
merged 3 commits into from
Jul 15, 2024
Merged

Conversation

corneliusroemer
Copy link
Member

Describe your pull request here


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

version: {{ version }}

source:
url: https://files.pythonhosted.org/packages/9c/96/971af8ac8519e8924624f70896c73d0d8a9491ee76095391c4da216d4aa4/pathogen_embed-{{ version }}.tar.gz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In another PR I noticed that the bot could update even pythonhosted urls! Amazing!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly - but I'm not sure it works 100% reliably?

It's definitely better to use the predictable URLs as for manual updating then only the sha needs to be changed.

Also, it keeps history/blame cleaner if we don't change the URL with every version bump.

@martin-g martin-g merged commit b3d5306 into master Jul 15, 2024
6 checks passed
@martin-g martin-g deleted the url-fix branch July 15, 2024 08:14
@huddlej
Copy link
Contributor

huddlej commented Jul 16, 2024

Amazing! Thanks, @corneliusroemer! I swear I tried the older-style pypi.io URL when I originally created this recipe but the URL never worked for me locally. Now it does, so maybe it was a random PyPI issue. Either way, thank you for your help!

@corneliusroemer
Copy link
Member Author

@huddlej Ah great, I didn't know. Is it possible that you tried the URL with a hyphen rather than underscore? I.e. you tried:

https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/pathogen-embed-{{ version }}.tar.gz

as opposed to

https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/pathogen_embed-{{ version }}.tar.gz

Setuptools changed the sdist path name from hyphen to underscore in a recent release (December 2023) and now it's no longer just {{name}}-{{version}}.tar.gz for hyphenated packages. The exact path depends on build system used, so one has to inspect manually.

See #48971

This is what caused nextstrain-cli to not be autobumped here in bioconda.

tcezard pushed a commit to tcezard/bioconda-recipes that referenced this pull request Sep 12, 2024
…9243)

* pathogen-embed: Use predictable url that autobump can use

* Update meta.yaml

* Update meta.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants