Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pgscatalog.core #48453

Merged
merged 8 commits into from
Jun 17, 2024
Merged

Add pgscatalog.core #48453

merged 8 commits into from
Jun 17, 2024

Conversation

nebfield
Copy link
Contributor

Add pgscatalog.core, a python package which contains core tools for working with polygenic scores (PGS) and the PGS Catalog

@nebfield nebfield changed the title Add pgscatalog core Add pgscatalog.core Jun 13, 2024
@nebfield
Copy link
Contributor Author

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Jun 13, 2024
@martin-g
Copy link
Contributor

@BiocondaBot please fetch artifacts

@BiocondaBot
Copy link
Collaborator

Package(s) built are ready for inspection:

Arch Package Zip File / Repodata CI Instructions
noarch pgscatalog.core-0.2.0-pyhdfd78af_0.tar.bz2 LinuxArtifacts.zip Azure
showYou may also use conda to install after downloading and extracting the zip file. From the LinuxArtifacts directory: conda install -c ./packages <package name>

Docker image(s) built:

Package Tag CI Install with docker
pgscatalog.core 0.2.0--pyhdfd78af_0 Azure
showImages for Azure are in the LinuxArtifacts zip file above.gzip -dc LinuxArtifacts/images/pgscatalog.core:0.2.0--pyhdfd78af_0.tar.gz | docker load


requirements:
host:
- python >=3.11,<4.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK support for Python 3.11 & 3.12 is available only in the bulk branch for now.
In master branch the available Python versions are 3.8, 3.9 and 3.10.
I wonder how this worked here.
The logs show that Python 3.12 has been installed - python: 3.12.3-hab00c5b_0_cpython

Copy link
Contributor Author

@nebfield nebfield Jun 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've downgraded the minimum version to 3.10 in a patch release (pgscatalog-core 0.2.1)

When I check the new logs and artifacts they're being built with 3.12 still - will the latest commit be OK to merge or do I have to put an upper limit on the python version range?

@nebfield
Copy link
Contributor Author

@BiocondaBot please fetch artifacts

@BiocondaBot
Copy link
Collaborator

Package(s) built are ready for inspection:

Arch Package Zip File / Repodata CI Instructions
noarch pgscatalog.core-0.2.1-pyhdfd78af_0.tar.bz2 LinuxArtifacts.zip Azure
showYou may also use conda to install after downloading and extracting the zip file. From the LinuxArtifacts directory: conda install -c ./packages <package name>

Docker image(s) built:

Package Tag CI Install with docker
pgscatalog.core 0.2.1--pyhdfd78af_0 Azure
showImages for Azure are in the LinuxArtifacts zip file above.gzip -dc LinuxArtifacts/images/pgscatalog.core:0.2.1--pyhdfd78af_0.tar.gz | docker load

@nebfield nebfield requested a review from martin-g June 17, 2024 07:47
@martin-g
Copy link
Contributor

@nebfield Support for 3.11 & 3.12 is really close - #33333 (comment)
I will review the PR now !

@martin-g
Copy link
Contributor

I still don't understand why/how it uses 3.12 for the build in master branch but since it works and no one else expressed any concerns I will merge the PR!

@martin-g martin-g merged commit bc228da into bioconda:master Jun 17, 2024
6 checks passed
@nebfield nebfield deleted the pgscatalog-core branch June 17, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants