Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pcre #1505

Closed
wants to merge 4 commits into from
Closed

Pcre #1505

wants to merge 4 commits into from

Conversation

sebastian-luna-valero
Copy link
Member

@sebastian-luna-valero sebastian-luna-valero commented May 9, 2016

  • I have read the guidelines above.
  • This PR adds a new recipe.
  • This PR updates an existing recipe.
  • This PR does something else (explain below).

Please @bioconda/core review this recipe

The recipe on the default channel has not been compiled with the --enable-utf option.

@johanneskoester
Copy link
Contributor

How urgent is this? If not that urgent, you could submit a PR to conda-recipes instead, so that the default package is updated... What do you think?

@sebastian-luna-valero
Copy link
Member Author

Many thanks!

This is not urgent but I am happy to submit a PR to conda-recipes if that is the best option. However, neither:
https://github.com/ContinuumIO/anaconda-recipes [package not there]

nor
https://github.com/conda/conda-recipes [version do not match]

are the repositories you are referring to, am I right?

Could you please point me to the correct repository?

Best regards,
Sebastian.

@johanneskoester
Copy link
Contributor

I would think its conda-recipes. As far as I know, this is the place to propose or update packages in the default channel. Even if the version does not match.

@sebastian-luna-valero
Copy link
Member Author

Many thanks!

Here is the PR for our reference:
conda-archive/conda-recipes#674

@jakirkham
Copy link

jakirkham commented May 13, 2016

@johanneskoester @sebastian-luna-valero, we have pcre in conda-forge.

Would welcome PRs there. 😄

@bgruening
Copy link
Member

PR against conda-forge would be great indeed. @jakirkham the problem for us is that we can not depend on conda-forge until we figured out the GCC issue. We would love to migrate a few repositories into the more general conda-forge repo.

Can we prioritise it? Google- hangout to discuss it further?

@jakirkham
Copy link

Basically, yes. Responded to you in this PR ( #1388 (comment) ) though.

@sebastian-luna-valero
Copy link
Member Author

Many thanks All, happy to close this PR as there is a better recipe already at conda-forge for pcre. @jakirkham congratulations for your great work!

I will bear this in mind next time a submit a recipe for a general purpose package.

@marcelm
Copy link
Contributor

marcelm commented Aug 4, 2016

As @sebastian-luna-valero said, this PR should be closed, right?

@johanneskoester
Copy link
Contributor

Indeed :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants