Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various updates #45

Merged
merged 5 commits into from
Nov 20, 2023
Merged

Various updates #45

merged 5 commits into from
Nov 20, 2023

Conversation

daler
Copy link
Member

@daler daler commented Nov 19, 2023

  • Removed MINICONDA_VER. It only appears to be used in the now-deprecated bioconda-actions repo, and we're using mambaforge anyway.
  • Added linux-aarch64 to the local channels. This is just to be complete -- I'm not sure this local channel setup is actually needed any more, because the pilot ARM builds worked OK. However, this may end up being important when there are many dependencies being built in which case the local channel should have priority.
  • Updated the readme to reflect current organization, so I can refer to it in the updated bioconda-docs. This info is better maintained here anyway rather than over on bioconda-docs.
  • Added configure-conda.sh to the test in this repo just to be complete.

note that this local channel setup may not be required anymore; the test
linux-aarch64 builds completed successfully even without this. But
adding it in for completion's sake.
Only appears to be used in the now-deprecated bioconda-actions repo.
Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @daler!

**`common.sh`:** contains environment variables that control versions.

**`install-and-set-up-conda.sh`:**
- downloads and installs conda using the Mambaforge distribution
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not use mambaforge anymore. Conda-forge discourages it and advertises miniforge.

With the release of Miniforge3-23.3.1-0, that incorporated the changes in conda-forge/miniforge#277, the packages and configuration of Mambaforge and Miniforge3 are now identical. The only difference between the two is the name of the installer and, subsequently, the default installation directory.
Given its wide usage, there are no plans to deprecate Mambaforge. If at some point we decide to deprecate Mambaforge, it will be appropriately announced and communicated with sufficient time in advance.
As of September 2023, the new usage of Mambaforge is thus discouraged. Bug reports specific to Mambaforge will be closed as won't fix.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was not aware of this, thanks for pointing it out.

This PR was mostly about documentation; do you think it's worth changing mambaforge -> miniforge in this PR? Theoretically it should not change anything in the build process since we're already on 23.3.1, so this is more a question of "do you think it will actually not change anything".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A different PR is ok. But we should get rid of it at some point.

1. Download the files, typically via:

```bash
wget https://raw.githubusercontent.com/bioconda/bioconda-common/master/{common,install-and-set-up-conda,configure-conda}.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe 3 separate commands? I guess the intention here is to copy-and-paste?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was documenting what we currently have. Could go either way, but I guess it's slightly easier to copy-paste this single line.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Agree.

@daler daler merged commit 535b4e9 into master Nov 20, 2023
2 checks passed
@daler daler deleted the update-readme branch November 20, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants