Skip to content

Commit a2773d3

Browse files
committed
Stop pinning urllib3 (only done for testing dep)
This fixes a problem where one cannot install `bioutils` into an environment where `urllib3` version 2 is being used. In other words, merely installing `bioutils` forces you to use `urllib3` version 1. There's a positive side effect too where installing `bioutils` no longer pulls in an unneeded dependency. Why are we pinning an unused dependency? ======================================== Previously, `vcrpy` (a test dependency) would not support urllib3 version 2. Tests would fail to run because of an attempted import of `urllib3.connectionpool.VerifiedHTTPSConnection` (not present in v2): #46 (comment) To resolve the error, `urllib3` was pinned to version `1.26.*`: #49 This definitely worked, but `urllib3` is *not* directly used by the package, only indirectly used during testing. Why pin a transitive test-only dependency? ========================================== Unfortunately, the way that `urllib3` was pinned doesn't just affect CI for this repository, but affects *any* environment in which `bioutils` is installed. Specifically, `urllib3` will *always* be installed as a dependency (or possibly downgraded from v2) when you `pip install bioutils`! There are ways we could have pinned `urllib3` only in CI without affecting package dependencies, but that's not important anymore. Is the original problem solved? =============================== Yes! `vcrpy` version 4.3.1 (released in May of 2023) started supporting `urllib3` version 2! > Support urllib3 v1 and v2. NOTE: there is an issue running urllib3 v2 > on Python older than 3.10, so this is currently blocked in the > requirements. Hopefully we can resolve this situation in the future. > Thanks to shifqu, hartwork, jairhenrique, pquentin, and vEpiphyte for > your work on this. https://vcrpy.readthedocs.io/en/latest/changelog.html
1 parent 453c1f1 commit a2773d3

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

pyproject.toml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ dynamic = ["version", "optional-dependencies"]
2929
dependencies = [
3030
"attrs",
3131
"requests",
32-
"urllib3~=1.26",
3332
]
3433

3534
[project.urls]
@@ -38,9 +37,9 @@ dependencies = [
3837

3938
[build-system]
4039
requires = [
41-
"setuptools >= 69.0",
42-
"setuptools_scm[toml] >= 8.0"
43-
]
40+
"setuptools >= 69.0",
41+
"setuptools_scm[toml] >= 8.0"
42+
]
4443
build-backend = "setuptools.build_meta"
4544

4645

@@ -58,8 +57,8 @@ doctest_optionflags = [
5857
"NORMALIZE_WHITESPACE",
5958
]
6059
markers = [
61-
"network: tests that require network connectivity",
62-
"slow: slow tests that should be run infrequently",
60+
"network: tests that require network connectivity",
61+
"slow: slow tests that should be run infrequently",
6362
]
6463
testpaths = [
6564
"tests"

0 commit comments

Comments
 (0)