Fix undefined behaviour of char bit shifting when combining classic i… #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Expose classic_combine function * Add exposition code * Fix syntax error * Expose calc_signature_size
* Expose classic_combine function * Add exposition code * Fix syntax error * Expose calc_signature_size * Expose classic combine as cmd instead
…ndices Previously when combining multiple classic indices into a single classic index, the contents of source indices are read in as `char`. During the interleaving process, depending on the current position of the destination index, both left and right shifts on the next char could be performed. However, there are a few undefined behaviours that could affect the results depending on the platform: 1. The signedness of a `char` is an undefined behaviour. Hence when bit shifting, the usual arithmetic conversion performed on the char is undefined. The char could be promoted to either signed int or unsigned int. 2. If the char is treated as signed int, the bit shifting (both left and right) is also undefined in pre-c++20 standards. The behaviour is platform dependent. This change fixes the issue by declare the contents read from source indices as `unsigned char`.
…ne-cmd Modify combine cmd
…ingmann#5) When combining classic indices, for each batch the combinations of rows from each constituent index are written to an output block. The output block is reused for next batch. As we use bitwise OR operation to combine rows from the constituent indices, the output block should be reset to all 0s before being reused. Otherwise, previous set bits will be carried over to next batch and accumulating false positives till the end of the batch processing loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ndices
Previously when combining multiple classic indices into a single classic
index, the contents of source indices are read in as
char. During theinterleaving process, depending on the current position of the destination
index, both left and right shifts on the next char could be performed.
However, there are a few undefined behaviours that could affect the results
depending on the platform:
charis an undefined behaviour. Hence whenbit shifting, the usual arithmetic conversion performed on the char is
undefined. The char could be promoted to either signed int or unsigned
int.
right) is also undefined in pre-c++20 standards. The behaviour is platform
dependent.
This change fixes the issue by declare the contents read from source
indices as
unsigned char.