Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hint about broken URLs when jupyterlab is missing #5

Merged
merged 2 commits into from
Sep 21, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
FROM python:3.7-slim
# install the notebook package
RUN pip install --no-cache --upgrade pip && \
pip install --no-cache notebook
pip install --no-cache notebook jupyterlab

# create user with a home directory
ARG NB_USER
Expand Down
6 changes: 5 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,11 @@ What this means in practice is that the `notebook` package must be installed and
RUN pip install --no-cache notebook
```

That's *almost* everything.
Note that if you are not installing `jupyterlab` in addition to the classic `notebook`,
you'll need to change your mybinder.org URLs from `/lab` to `/tree` as described
[here](https://mybinder.readthedocs.io/en/latest/howto/user_interface.html#jupyterlab).
Otherwise, you might get a "404: Not Found" error when launching your project on binder.
Now that's *almost* everything.

The remaining piece is that the specified user must be able to *start* the notebook,
which requires certain permissions like being able to write to the home directory.
Expand Down