Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hint about broken URLs when jupyterlab is missing in truly-minimal example #4

Closed
wants to merge 1 commit into from

Conversation

N-Coder
Copy link
Contributor

@N-Coder N-Coder commented Sep 17, 2021

@N-Coder N-Coder changed the title add hint about broken URLs when jupyterlab is missing add hint about broken URLs when jupyterlab is missing in truly-minimal example Sep 17, 2021
@minrk
Copy link
Collaborator

minrk commented Sep 21, 2021

closing in favor of #5

@minrk minrk closed this Sep 21, 2021
@N-Coder
Copy link
Contributor Author

N-Coder commented Sep 21, 2021

@minrk note that these two PRs want to merge into two different branches:
#4: 1 commit into binder-examples:truly-minimal from N-Coder:patch-1
#5: 2 commits into binder-examples:master from N-Coder:patch-2
If we don't merge this PR, the truly-minimal branch, which is also referenced from the docs as alternative, truly-minimal example, will remain broken.


See here:

The absolute bare minimum for this is to set HOME to /tmp so that it's writable,
which would make the shortest, smallest Dockerfile that works on Binder:

FROM python:3.7-slim
RUN pip install --no-cache notebook
ENV HOME=/tmp

which you can try out: Binder

And the binder badge points to https://mybinder.org/v2/gh/binder-examples/minimal-dockerfile/truly-minimal, i.e. said branch of this repo.

@minrk
Copy link
Collaborator

minrk commented Sep 21, 2021

Thanks for that clarification! I forgot about the other branch, I'll make sure both install both notebook and lab, which should be considered the truly minimal baseline to be "supported", even if it may technically work for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants