Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: stricter types for graphqlB2B fetch #211

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

icatalina
Copy link
Contributor

@icatalina icatalina commented Jan 13, 2025

Jira: FE-418

What/Why?

Move type definition to the fetch function. This is in preparation for stricter types.

Fix some typos, cspell complains otherwise.

Rollout/Rollback

Revert

Testing

n/a

Move type definition to the fetch function. This is in preparation for
stricter types.

Fix some typos, cspell complains otherwise.
@icatalina icatalina requested review from LeoChowChina and a team as code owners January 13, 2025 18:16
Copy link
Contributor

@bc-victor bc-victor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just as FYI we installed graphql-codegen awhile ago for stricter types, consider using it or removing it for something else if you add return types in the future

@icatalina
Copy link
Contributor Author

that's the plan, I need to do some cleaning first... 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants