Fix bug where a blank password could be generated.

biddster · Apr 13, 2014 · 43566e9 · 43566e9
1 parent 8abbef9
commit 43566e9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pom.xml b/pom.xml
@@ -22,15 +22,14 @@
     <groupId>uk.co.biddell</groupId>
     <artifactId>DiceWare</artifactId>
     <packaging>jar</packaging>
-    <version>1.0.1-SNAPSHOT</version>
+    <version>1.0.1</version>
     <name>DiceWare</name>
     <url>http://maven.apache.org</url>
 
     <properties>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
     </properties>
 
-
     <reporting>
         <plugins>
             <plugin>

diff --git a/src/main/java/uk/co/biddell/diceware/dictionaries/DiceWare.java b/src/main/java/uk/co/biddell/diceware/dictionaries/DiceWare.java
@@ -223,7 +223,8 @@ public DiceWords createPassphrase(final int numberOfWords, final boolean maximis
         }
         if (actualLength < 14) {
             // Less than 14 is not recommended according to diceware so throw again
-            createPassphrase(numberOfWords, maximiseSecurity);
+        	// Should probably try this a few times.
+            return createPassphrase(numberOfWords, maximiseSecurity);            
         } else {
             int extraSecurityWord = -1;
             if (maximiseSecurity) {