Tranform ebook on the fly (while syncing) using kebubify and synchonious messengers #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ragusa87
commented
Aug 25, 2024
•
ragusa87
commented
- Test if the device take the epub or kepub format by default
ragusa87
commented
Aug 25, 2024
| @@ -21,12 +28,17 @@ protected function getDownloadUrls(Book $book, KoboDevice $kobo, ?array $filters | |||
|
|
|||
| $response = []; | |||
|
|
|||
| $formats = ['EPUB3']; // EPUB3 is required for Kobo | |||
| $formats = [self::EPUB3_FORMAT]; // At least EPUB3 is required for Kobo | |||
| if ($this->kepubifyEnabler->isEnabled()) { | |||
There was a problem hiding this comment.
I am not sure if the kobo takes the EPUB3 or KEPUB format by default.
To be tested with a device.
(You should have advanced features such as "notes" in the kepub format)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.