Merge pull request #201 from bhollis/fix-firefox-encode

Override Firefox content type guessing
bhollis · May 24, 2023 · 0722718 · 0722718
2 parents e9a65d7 + 587a738
commit 0722718
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## JSONView 2.4.2
+
+- Fix mangled encoding in Firefox
+
 ## JSONView 2.4.1
 
 - Fix mangled arrows

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
  "id": "[email protected]",
- "version": "2.4.1",
+ "version": "2.4.2",
  "name": "jsonview",
  "title": "JSONView",
  "description": "View JSON documents in the browser.",

diff --git a/src/background.ts b/src/background.ts
@@ -30,11 +30,12 @@ function transformResponseToJSON(details: chrome.webRequest.WebResponseHeadersDe
  let content = "";
 
  filter.ondata = (event) => {
- content = content + dec.decode(event.data);
+ content += dec.decode(event.data, { stream: true });
  };
 
  filter.onstop = (_event: Event) => {
- const outputDoc = `<!DOCTYPE html><html><body><pre>${content}</pre></body></html>`;
+ content += dec.decode();
+ const outputDoc = `<!DOCTYPE html><html><head><meta charset="utf-8"></head><body><pre>${content}</pre></body></html>`;
  filter.write(enc.encode(outputDoc));
  filter.disconnect();
  };

diff --git a/src/manifest.json b/src/manifest.json
@@ -1,7 +1,7 @@
 {
  "manifest_version": 2,
  "name": "JSONView",
- "version": "2.4.1",
+ "version": "2.4.2",
  "description": "__MSG_extensionDescription__",
  "author": "Benjamin Hollis",
  "homepage_url": "https://jsonview.com/",