Update 3dtrees_standardization v1.1#1747
Merged
bgruening merged 14 commits intobgruening:masterfrom Jan 13, 2026
Merged
Conversation
bgruening
reviewed
Jan 9, 2026
bgruening
reviewed
Jan 9, 2026
bgruening
reviewed
Jan 9, 2026
bgruening
reviewed
Jan 9, 2026
…ction parameter. Changed output expectations for tests and clarified documentation for collection mode validation.
bgruening
reviewed
Jan 12, 2026
bgruening
reviewed
Jan 12, 2026
bgruening
reviewed
Jan 12, 2026
bgruening
reviewed
Jan 12, 2026
| #else: | ||
| mkdir -p input_files && | ||
| #for $f in $mode.input_collection | ||
| cp '$f' input_files/'${f.element_identifier}.laz' && |
Owner
There was a problem hiding this comment.
Suggested change
| cp '$f' input_files/'${f.element_identifier}.laz' && | |
| cp '$f' './input_files/${f.element_identifier}.laz' && |
Co-authored-by: Björn Grüning <bjoern@gruenings.eu>
Co-authored-by: Björn Grüning <bjoern@gruenings.eu>
bgruening
approved these changes
Jan 12, 2026
bgruening
reviewed
Jan 12, 2026
| <param argument="--min-density" type="integer" min="1" max="10000" value="10" | ||
| label="Minimum Point Density" | ||
| help="Minimum acceptable point density in points per square meter. Default: 10 pts/m²"/> | ||
| <param argument="--removeable_attributes" type="text" value="" optional="true" |
Owner
There was a problem hiding this comment.
Those attributes can have spaces and should be space separated? This looks dangerous and is probably hard to quote on the command line. Single quotes should also be forbidden as input etc ... something to work on. Can you please put that on your todo list?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: