Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to check the status of the services. #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

almet
Copy link

@almet almet commented Dec 11, 2013

(rather than only displaying their status)

  • Add a connection string to the services. A connection-string is in the form
    {protocol}://{hostname}:{port}.
  • Add a celery task able to check the status of a service, given a protocol.
  • Add a "check_status" django command.
  • Update the base settings to use celery
  • use the settings/deploy.py if it exists
  • explicitely pin the versions in the requirements.txt file
  • display the connection string on the detail page of the service

(rather than only displaying their status)

- Add a connection string to the services. A connection-string is in the form
  {protocol}://{hostname}:{port}.
- Add a celery task able to check the status of a service, given a protocol.
- Add a "check_status" django command.
- Update the base settings to use celery
- use the settings/deploy.py if it exists
- explicitely pin the versions in the requirements.txt file
- display the connection string on the detail page of the service
@bfirsh
Copy link
Owner

bfirsh commented Dec 11, 2013

Thanks! I've left a few comments on the commit.

@almet
Copy link
Author

almet commented Dec 11, 2013

Thanks for taking the time to review that, I don't think I'll be able to find the time to actually commit myself to tidy up everything, so I'll let whoever wants to do it proceed.

(this code was made something like a year ago, so there are possible flaws in there, yup).

@bfirsh
Copy link
Owner

bfirsh commented Dec 12, 2013

No worries! Good to get this lined up for PR. I may have time to fix it myself at some point, but I'm quite busy at the moment.

@bsdlp
Copy link
Collaborator

bsdlp commented Dec 13, 2013

thanks @ametaireau, I'll try to work through some of @bfirsh's suggestions and get it ready for merge

@bsdlp bsdlp mentioned this pull request Dec 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants