Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect CSS (breaking) #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

dvsmc
Copy link

@dvsmc dvsmc commented Jun 18, 2023

  1. Various style loaders detect incorrect css and fails.
  2. Fixed invalid CSS in general.

1. Various style loaders detect incorrect css and fails.
2. Fixed invalid CSS in general.
@dvsmc dvsmc changed the title Update Notifications.svelte Fix incorrect CSS (breaking) Jul 13, 2023
@dvsmc
Copy link
Author

dvsmc commented Aug 12, 2023

@nosovk please merge when you can

@nosovk
Copy link

nosovk commented Aug 13, 2023

I have no access to merge, I think that only @antony can

@nosovk
Copy link

nosovk commented Aug 13, 2023

Actually I was doing #48 and just checked other PRs to verify that nobody else have done that before, and saw your PR which seems good to me

nosovk pushed a commit to nosovk/svelte-notifications that referenced this pull request Aug 15, 2023
@nosovk
Copy link

nosovk commented Aug 15, 2023

you may use
npm i github:nosovk/svelte-notifications#fixup
which has your fix and also changes from my branch precompiled. It's a temporary solution, but it works for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants