-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated for protocol version 12 #5
base: master
Are you sure you want to change the base?
Conversation
Which version of OrientDB did you develop against? I'm getting integration test failures in version 1.1.0 and mismatches in protocol expectations in version 1.2.0. I noticed that you modified several tests. Were you testing against a fresh install of OrientDB, or did you modify some of its internal data before doing your testing? |
This is based off stock 1.3 database. I more or less clobbered the version 9 stuff but I could implement it as extensions to 9, similar to what you did in relation from version 7 to 9. On version 1.3 all unit tests pass except for one which receives a heap error. I am hoping to determine the cause and push a fix. I have every intent of implementing all new version capabilities. I have great interest in your library and I have begun implementing an object relational library which I'd like to share soon. Ryan Fields [email protected] wrote:
|
I'm not seeing an OrientDB download for 1.3. Did you build it from source? There is a lot of reorganizing I want to do with the code, but I'd still like to continue the trend of building up each protocol as an extension of the previous. While I don't believe there are many users of this gem, I don't want to break backward compatibility yet without a really compelling reason. I pulled your changes into a branch on my local machine to review them and merge. I put Protocol9 back in, so you don't need to worry about dealing with that. As soon as I can get the tests passing, I'll merge into master and bump the gem version. If you have any luck resolving the heap dump, let me know. It happens on Orient 1.1 and 1.2 as well, so resolving it on any version is likely to resolve it for all. |
Yes. Originally I was using the stable version downloaded from their After some digging this was revealed to be solved in latest version from To reproduce my results from clean build.... Install ant, jdk, etc. svn checkout http://orient.googlecode.com/svn/trunk/ orient-read-onlycd orient-read-only/trunkant install(this will yield ../releases which has binary dist) cd ../releases/ORIENTDB-1.3-RELEASE/bin(customize configuration of orientdb server for root password, bind IP bash ./server.shAfter that the unit tests will pass (except for the aforementioned heap This implements version 12 of the protocol. Don't worry about "not many users" because I think this gem is great and On 11/05/2012 11:18 PM, Ryan Fields wrote:
|
josh@inspiron620mt:~/orient_db_client$ rake test:integration Running tests:...................S.. 22 tests, 58 assertions, 0 failures, 0 errors, 1 skips All unit tests passing now.... killed several bugs regarding protocol 12 implementation.... |
I'm having trouble opening databases on the 1.3.0-SNAPSHOT (downloaded here: oss.sonatype.org/content/repositories/snapshots/com/orientechnologies/orientdb/1.3.0-SNAPSHOT/). |
A good way to debug the NetworkBinary protocol is to reference This will print out Orient's activity relating to binary input / output. Using this method I was able to do a great deal of work with the library. |
this allows for non-idempotent commands (create class, etc.) to be run
I've updated the library for version 12... let me know what you think