Merged
Conversation
the baobit commit will be injected at final file packaging time
in order to prevent the recursive introspection issue, the code image is built from a reproducible toolchain from a given commit on xous-core. However, in order for us to record *which* toolchain was used, it's impossible to do this without modifying the commit hash of the toolchain - thus making it impossible to know what toolchain was actually used to build the reproducible code. The fix to this is to out-of-band, at the final signature time, patch over a field in the signature header expressly laid out to accommodate the hash.
the sealed data records are laid out with some extra space at the end for future expansion. The first such expansion added is a toolchain hash, which allows us to note which toolchain is required to reproduce the current image. The change is backward compatible so the version field of the record is *not* incremented.
- include the toolchain hash for reproduction iff it is specified - for the code hash, report *only* the code region, none of the signature headers. This should match exactly what is reported by the *_presign.img artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains the code needed to shuffle the baobit toolchain injection until the final signing operation.