MAJ React + Typescript #1174
Merged
MAJ React + Typescript #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Enzyme ne fonctionne pas encore avec React 17 et l'implémentation d'Enzyme est critiquée car elle repose sur les noms internes au code React pour venir le patcher. J'ai l'impression qu'une partie de la communauté est partie sur react-testing-library https://testing-library.com/docs/react-testing-library/migrate-from-enzyme. Si la migration est facile et rapide, je l'ajouterai à cette PR. |
Pas de changement de fonctionnalités Plus besoin d'importer React pour utiliser JSX
Plein de nouveautés et notamment la possibilité de "programmer" les types chaînes littérales qui nous sera utile par exemple pour vérifier statiquement la validité d'une *expression* publicode dans `engine.evaluate`. https://devblogs.microsoft.com/typescript/announcing-typescript-4-1/ ⬆ MAJ ESLint-typescript pour la compatibilité
Utilisation d'un fork en attendant que React 17 soit supporté par Enzyme. J'ai essayé rapidement la librairie https://testing-library.com/docs/react-testing-library/migrate-from-enzyme vers laquelle certains utilisateurs d'Enzyme semblent maintenant se tourner, mais la migration est non triviale (alors même que nous n'avons qu'un seul fichier qui utilise les tests Enzyme !)
mquandalle
force-pushed
the
react-17
branch
3 times, most recently
from
0c4de27
to
044954b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attendons TS 4.1 stable pour merger (sortie mi-novembre)
Enzyme: enzymejs/enzyme#2429