Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1492 utiliser exclusivement des donnees matomo #151

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

baptou12
Copy link
Contributor

@baptou12 baptou12 commented Nov 6, 2023

⚠️ Y'a une partie refacto, plus facile à lire commit par commit

Ticket: https://trello.com/c/fLgK2DC3/1492-utiliser-exclusivement-des-donn%C3%A9es-matomo-dans-le-premier-tunnel-de-conversion

Need: betagouv/aides-jeunes#4056

Résultats:
image

Note: if you have `nvm` installed you just have to
do `nvm use` to pick good version
Note:
- Première page question simulateur
- Deuxième page question simulateur
- Page de Résultats
@baptou12 baptou12 force-pushed the 1492-utiliser-exclusivement-des-donnees-matomo branch from 8bc5b38 to f49509b Compare November 6, 2023 10:43
@baptou12 baptou12 marked this pull request as ready for review November 6, 2023 10:49
Copy link
Contributor

@Shamzic Shamzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je ne suis pas encore très familier à React, donc j'ai pas grand chose à dire sur le code. C'est fonctionnel de mon côté !

En espérant que les données attendues en local soient bonnes :

image

@baptou12
Copy link
Contributor Author

baptou12 commented Nov 7, 2023

Good, je merge une fois que le back est mergé

@baptou12 baptou12 merged commit 0a41b13 into main Nov 7, 2023
3 checks passed
@guillett guillett deleted the 1492-utiliser-exclusivement-des-donnees-matomo branch February 7, 2024 09:59
@guillett guillett added this to the Passé milestone Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants