Merge pull request #146 from betagouv/remove_useless_useeffect

refacto: remove useless useEffect

pages/institutions.js

@@ -1,4 +1,4 @@
-import { useState, useEffect } from "react"
+import { useState } from "react"
 
 import useFetchInstitutionsData from "../hooks/fetch-institutions-data"
 import InfoIcon from "../components/InfoIcon"
@@ -39,30 +39,24 @@ const filterData = (
 
 const InstitutionsStats = () => {
   const { dataService, loading, error } = useFetchInstitutionsData()
-  const [results, setResults] = useState([])
 
   const [queryName, setQueryName] = useState("")
   const [queryCode, setQueryCode] = useState("")
   const [selectedType, setSelectedType] = useState(allType)
   const [sortKey, setSortKey] = useState(null)
   const [sortOrder, setSortOrder] = useState(defaultSortOrder)
 
-  useEffect(() => {
-    if (!dataService) {
-      return
-    }
-
-    setResults(
-      filterData(
-        dataService,
-        queryName,
-        queryCode,
-        selectedType,
-        sortKey,
-        sortOrder,
-      ),
+  let results = []
+  if (dataService) {
+    results = filterData(
+      dataService,
+      queryName,
+      queryCode,
+      selectedType,
+      sortKey,
+      sortOrder,
     )
-  }, [queryName, queryCode, selectedType, sortKey, sortOrder, dataService])
+  }
 
   const handleHeaderClick = (newSortKey) => {
     if (newSortKey === sortKey) {