Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ajoute un cron mensuel pour exécuter le script de génération de stats MongoDB #142

Merged
merged 4 commits into from
Sep 3, 2023
Merged

Ajoute un cron mensuel pour exécuter le script de génération de stats MongoDB #142

merged 4 commits into from
Sep 3, 2023

Conversation

Shamzic
Copy link
Contributor

@Shamzic Shamzic commented Jul 5, 2023 •
edited
Loading

Tâche associée

L'exécution est à minuit pile un peu par défaut, peut-être que ce timing est à discuter

@Shamzic Shamzic requested a review from a team July 5, 2023 14:15
@Shamzic Shamzic self-assigned this Jul 5, 2023
baptou12
baptou12 suggested changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@baptou12 baptou12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cf name du cron

Shamzic added a commit that referenced this pull request Jul 6, 2023
@Shamzic @baptou12
Update roles/bootstrap/tasks/setup_cron.yaml
a09e06c 
Suite au commentaire de Baptiste : #142 (comment)

Co-authored-by: Baptiste Maurel <[email protected]>
baptou12
baptou12 approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@baptou12 baptou12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM juste une question en suspens sur la périodicité

@Shamzic
Copy link
Contributor Author

Shamzic commented Jul 7, 2023 •
edited
Loading

LGTM juste une question en suspens sur la périodicité

Preneur d'un second avis de l'équipe @betagouv/aides-jeunes dans ce cas 👍

@Cugniere Cugniere mentioned this pull request Aug 29, 2023
Merged
Cugniere
Cugniere suggested changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@Cugniere Cugniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La PR est ok pour moi ; il faut juste mettre à jour la commande utilisée pour lancer la génration des stats

@baptou12
Copy link
Contributor

La PR est ok pour moi ; il faut juste mettre à jour la commande utilisée pour lancer la génration des stats

  • le changement de la fréquence de every day à every month :-)

@Shamzic Shamzic changed the title Ajoute un cron quotidien pour exécuter le script de génération de stats MongoDB Ajoute un cron mensuel pour exécuter le script de génération de stats MongoDB Sep 1, 2023
@Shamzic Shamzic force-pushed the ajoute-cron-mongo-stats-daily branch from af1a3c8 to 83eb777 Compare September 1, 2023 09:52
Cugniere
Cugniere approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@Cugniere Cugniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok pour moi

@Shamzic Shamzic merged commit 98a3870 into main Sep 3, 2023
4 checks passed
@guillett guillett deleted the ajoute-cron-mongo-stats-daily branch February 7, 2024 09:50
@guillett guillett added this to the Passé milestone Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cugniere Cugniere Cugniere approved these changes

@baptou12 baptou12 baptou12 approved these changes

Assignees

@Shamzic Shamzic

Labels
None yet
Projects
None yet
Milestone
Passé
Development

Successfully merging this pull request may close these issues.
4 participants
@Shamzic @baptou12 @Cugniere @guillett