Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve flags parsing #461

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat: improve flags parsing #461

wants to merge 5 commits into from

Conversation

Doozers
Copy link
Collaborator

@Doozers Doozers commented Sep 15, 2022

relate to #457

@auto-add-label auto-add-label bot added the enhancement New feature or request label Sep 15, 2022
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Sep 15, 2022
@Doozers
feat: implement moul/climan
42eb923 
Signed-off-by: ismael FALL <[email protected]>
moul
moul reviewed Sep 16, 2022
View reviewed changes
go/cmd/yolo/main.go Outdated Show resolved Hide resolved
moul
moul reviewed Sep 16, 2022
View reviewed changes
go/cmd/yolo/main.go Outdated Show resolved Hide resolved
moul
moul reviewed Sep 16, 2022
View reviewed changes
go/cmd/yolo/main.go Outdated Show resolved Hide resolved
moul
moul reviewed Sep 16, 2022
View reviewed changes
go/cmd/yolo/main.go

func main() {
err := yolo(os.Args)
err := yolo(os.Args[1:])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check how things are going when you run yolo without additional parameter?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

moul
moul reviewed Sep 16, 2022
View reviewed changes
go/cmd/yolo/server.go Outdated Show resolved Hide resolved
moul
moul reviewed Sep 16, 2022
View reviewed changes
go/cmd/yolo/server.go Outdated Show resolved Hide resolved
moul
moul reviewed Sep 16, 2022
View reviewed changes
go/cmd/yolo/server.go Outdated Show resolved Hide resolved
@Doozers
fix: apply review comments
c0c27bd 
Signed-off-by: ismael FALL <[email protected]>
@Doozers Doozers requested a review from moul September 19, 2022 11:01
@Doozers Doozers marked this pull request as ready for review September 19, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moul moul Awaiting requested review from moul moul is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request 🔍 Ready for Review Pull Request is not reviewed yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Doozers @moul