Updated selectors for JangoController [2023-03-13] #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated standards & fix manifest warnings.
…ke actions (to be used with websites that require it, e.g. Jango)
… the callback (cleaner)
# Conflicts: # Gruntfile.js # README.md # code/js/controllers/JangoController.js # package.json
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Bump! Can you have a look at this when you have time? @berrberr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating Jango selectors again after a long time :)
Good news: confirmation of like/dislike is not needed anymore.
Bad news: I could not bind the "like" action to a selector that acts as a toggle (click once -> like, click twice -> remove the like).
Also, like and dislike actions only work in the "Now Playing" tab.