Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DH-25] Enable config to test RTC in dev hub #6757

Closed
wants to merge 1 commit into from

Conversation

balajialg
Copy link
Contributor

Copy link
Contributor

@felder felder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to put this in staging.yaml until we've tested it? This is in devhub so it may not matter I guess. That's really my only concern cuz I'm gonna assume the config is right. ;-) So if the answer is "no" to staging.yaml, then I approve!

@ryanlovett
Copy link
Collaborator

Is this configuration needed? i.e. most server extensions are now enabled when you install them.

We used to enable the TempFileYStore so that the associated sqlite db files were put in /tmp/ rather than user's home directories.

I honestly don't know if we still want this. There can periodically be file locking issues with sqlite files on NFS, but it isn't always the case. It might be worth not adding this back, just to test. IIRC, this /tmp configuration also caused reliability issues that weren't present when it wasn't enabled.

@balajialg
Copy link
Contributor Author

@felder Sure, I will keep this in mind for my future PRs. @ryanlovett Good to know! I have seen this config added during the initial iteration of RTC but wasn't sure about the latest changes. I will close this PR for now.

PS: I remember the crazy times when NFS/Sqlite combo were causing reliability issues.

@balajialg balajialg closed this Feb 6, 2025
@ryanlovett
Copy link
Collaborator

@balajialg It may still be needed. You might try testing with just the package installed.

@balajialg
Copy link
Contributor Author

balajialg commented Feb 10, 2025

@ryanlovett Yeah, I did some testing in the dev-staging hub without the config changes and with the package installed. Despite adding Jupyter-Collaboration package in Dev Hub's primary image, RTC is still not enabled. However, that wasn't the case when I built the image locally on my device.

I will probably hubploy this config change to dev-staging and evaluate whether it works. If it does, I will re-open the PR.

@balajialg
Copy link
Contributor Author

@ryanlovett I just observed that all three profiles in Dev Hub use dev-secondary images? Seems like dev-primary-image is not used by any hubs (ironically). I thought the default was dev-primary-image based on the name.

@ryanlovett
Copy link
Collaborator

@balajialg It used to be there. Maybe things changed when the image repos were split out? Not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants