Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DH-361] adding nature hub #6053

Merged
merged 1 commit into from
Aug 30, 2024
Merged

[DH-361] adding nature hub #6053

merged 1 commit into from
Aug 30, 2024

Conversation

felder
Copy link
Contributor

@felder felder commented Aug 30, 2024

@felder felder requested a review from shaneknapp August 30, 2024 18:53
shaneknapp
shaneknapp approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@shaneknapp shaneknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM+++

looks absolutely complete, and thanks for the doc updates. i guess we merge, and see what happens next? ;)

@shaneknapp shaneknapp merged commit 6f43327 into berkeley-dsep-infra:staging Aug 30, 2024
22 checks passed
@felder felder deleted the felder_DH-361 branch August 30, 2024 19:34
felder added a commit that referenced this pull request Aug 30, 2024
@felder
Merge pull request #6054 from berkeley-dsep-infra/staging
6df61ae 
[DH-361] merging #6053 nature hub creation to prod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaneknapp shaneknapp shaneknapp approved these changes

Assignees
No one assigned
Labels
bash build-infra configuration documentation Issues around adding and modifying docs helm-config node-placeholder-deployment singleuser-image
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felder @shaneknapp