Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DH-301] Fix kubectl auth and logic for deploying #5995

Merged
merged 2 commits into from
Aug 22, 2024
Merged

[DH-301] Fix kubectl auth and logic for deploying #5995

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1ae27b
add project id
shaneknapp Aug 22, 2024
5830cf7
add proper logic for deploying or not
shaneknapp Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/deploy-jupyterhub-base-images.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,11 @@ jobs:
echo "DEPLOY=1" >> $GITHUB_ENV
fi
done
echo "Deploying base hub images to all deployments"
if [[ -n "${DEPLOY}" ]]; then
echo "Deploying base hub images to all deployments"
else
echo "No hub images to deploy"
fi

- name: Setup python
if: ${{ env.DEPLOY }}
Expand Down Expand Up @@ -57,11 +61,12 @@ jobs:
install_components: 'gke-gcloud-auth-plugin,kubectl'

- name: Get GKE credentials for the cluster
if: ${{ env.DEPLOY }}
uses: 'google-github-actions/get-gke-credentials@v2'
with:
cluster_name: ${{ secrets.GKE_CLUSTER_NAME }}
location: ${{ secrets.GKE_CLUSTER_LOCATION }}

project_id: ${{ secrets.GCP_PROJECT_ID }}

- name: Install SOPS
if: ${{ env.DEPLOY }}
Expand Down
Loading