Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DH-231] Enable gh-scoped-creds for D-Lab #5536

Merged
merged 1 commit into from
Feb 14, 2024
Merged

[DH-231] Enable gh-scoped-creds for D-Lab #5536

merged 1 commit into from
Feb 14, 2024

Conversation

balajialg
Copy link
Contributor

@shaneknapp
Copy link
Contributor

this looks good, but i have one question... i went to the github app for this (https://github.com/apps/dlab-berkeley-datahub-access) and it seems that we're not done w/the configuration?

image

Next: Confirm your installation location.

i haven't added github scoped creds before, so i'm unsure if we're done w/setup and this is expected or not... i did read the instructions but i don't want to start pushing random buttons and breaking things. XD

https://github.com/jupyterhub/gh-scoped-creds?tab=readme-ov-file#github-app-configuration

@balajialg
Copy link
Contributor Author

balajialg commented Feb 14, 2024

@shaneknapp My understanding is that you need to install the Github app to the repo you want gh-scoped-creds to have access to. After that, you can push changes to that particular repository from the hub. Try installing the app in a personal Github repo?

I just enabled this app for a github repo below and the config seems to be fine (from an installation standpoint),

image

@shaneknapp shaneknapp merged commit b691828 into berkeley-dsep-infra:staging Feb 14, 2024
21 checks passed
@shaneknapp
Copy link
Contributor

got it. i set up my own app and went through the process. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants