Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(boonet): min stake upgrade on boonet fork 4 #2333

Merged
merged 3 commits into from
Dec 31, 2024
Merged

Conversation

calbera
Copy link
Contributor

@calbera calbera commented Dec 31, 2024

boonet branch is currently synced with v0.6.1. After merging this PR, future releases for the boonet network can be cut off of the boonet branch.

Effective changes are to validator set processing:

  • The min stake (or EjectionBalance) is now set to 250k BERA
  • The EffectiveBalanceIncrement (not the same as minimum deposit amount on the execution layer deposit contract) is now set to 10k BERA

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 82.66667% with 13 lines in your changes missing coverage. Please review.

Project coverage is 30.89%. Comparing base (b979363) to head (463b22d).
Report is 1 commits behind head on boonet.

Files with missing lines Patch % Lines
chain-spec/chain/chain_spec.go 0.00% 10 Missing ⚠️
cli/commands/genesis/root.go 0.00% 1 Missing ⚠️
state-transition/core/state/upgrade.go 90.90% 1 Missing ⚠️
state-transition/core/state_processor_staking.go 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           boonet    #2333      +/-   ##
==========================================
+ Coverage   30.70%   30.89%   +0.19%     
==========================================
  Files         331      331              
  Lines       15445    15498      +53     
  Branches       20       20              
==========================================
+ Hits         4742     4788      +46     
- Misses      10384    10391       +7     
  Partials      319      319              
Files with missing lines Coverage Δ
config/spec/base.go 100.00% <100.00%> (ø)
config/spec/boonet.go 100.00% <100.00%> (ø)
state-transition/core/state_processor.go 40.99% <100.00%> (+1.38%) ⬆️
state-transition/core/state_processor_genesis.go 50.39% <100.00%> (+1.61%) ⬆️
...tate-transition/core/state_processor_validators.go 71.87% <100.00%> (+1.70%) ⬆️
cli/commands/genesis/root.go 0.00% <0.00%> (ø)
state-transition/core/state/upgrade.go 78.78% <90.90%> (+6.06%) ⬆️
state-transition/core/state_processor_staking.go 54.49% <75.00%> (+0.55%) ⬆️
chain-spec/chain/chain_spec.go 17.11% <0.00%> (-0.98%) ⬇️

@calbera calbera marked this pull request as ready for review December 31, 2024 08:25
@@ -179,7 +179,7 @@ func (sp *StateProcessor[
)
}
minEffectiveBalance := math.Gwei(
sp.cs.EjectionBalance() + sp.cs.EffectiveBalanceIncrement(),
sp.cs.EjectionBalance(false) + sp.cs.EffectiveBalanceIncrement(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@calbera question: should the Increment change too? I would say so.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator

@abi87 abi87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I would change the EffectiveBalanceIncrement to a value that make sense given the new min and max

@calbera calbera requested a review from abi87 December 31, 2024 20:57
@calbera calbera merged commit 9f90b2d into boonet Dec 31, 2024
16 checks passed
@calbera calbera deleted the min-stake-upgrade branch December 31, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants