-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(boonet): min stake upgrade on boonet fork 4 #2333
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## boonet #2333 +/- ##
==========================================
+ Coverage 30.70% 30.89% +0.19%
==========================================
Files 331 331
Lines 15445 15498 +53
Branches 20 20
==========================================
+ Hits 4742 4788 +46
- Misses 10384 10391 +7
Partials 319 319
|
@@ -179,7 +179,7 @@ func (sp *StateProcessor[ | |||
) | |||
} | |||
minEffectiveBalance := math.Gwei( | |||
sp.cs.EjectionBalance() + sp.cs.EffectiveBalanceIncrement(), | |||
sp.cs.EjectionBalance(false) + sp.cs.EffectiveBalanceIncrement(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@calbera question: should the Increment change too? I would say so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I would change the EffectiveBalanceIncrement to a value that make sense given the new min and max
boonet
branch is currently synced withv0.6.1
. After merging this PR, future releases for the boonet network can be cut off of theboonet
branch.Effective changes are to validator set processing:
EjectionBalance
) is now set to 250k BERAEffectiveBalanceIncrement
(not the same as minimum deposit amount on the execution layer deposit contract) is now set to 10k BERA