Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Read Shell Escape Issue #6

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Conversation

LuminousPath
Copy link
Contributor

Hey

I noticed that when trying to read in the gradle file, when I was using a regular string vs the string that was coming in from the get_gradle_file_path I wasn't getting errors like Invalid argument @ rb_sysopen so I tried removing the shellescape portion and it got rid of the errors.

problem is (This might only be a windows thing) shellescape creates escaped double quotes:
"\"C:/Users/Guy/Documents/Cool Project/project/android/build.gradle\""
vs
"C:/Users/Guy/Documents/Cool Project/project/android/build.gradle"

and so causes issues when File.open or File.new tries to read it. Also by design the File class doesn't need shell escaped strings.

Made a pull request to fix it, not sure how many other people (if anyone) encountered this but it's a pretty straightforward fix

@igorlamos igorlamos merged commit 6e141a4 into beplus:master Nov 24, 2021
@igorlamos
Copy link
Contributor

Thanks, @LuminousPath.

@soethan99
Copy link

Not yet @igorlamos , I have open my issue in #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants