Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey
I noticed that when trying to read in the gradle file, when I was using a regular string vs the string that was coming in from the
get_gradle_file_path
I wasn't getting errors likeInvalid argument @ rb_sysopen
so I tried removing theshellescape
portion and it got rid of the errors.problem is (This might only be a windows thing)
shellescape
creates escaped double quotes:"\"C:/Users/Guy/Documents/Cool Project/project/android/build.gradle\""
vs
"C:/Users/Guy/Documents/Cool Project/project/android/build.gradle"
and so causes issues when File.open or File.new tries to read it. Also by design the
File
class doesn't need shell escaped strings.Made a pull request to fix it, not sure how many other people (if anyone) encountered this but it's a pretty straightforward fix