Enabled the ability for init-auth to allow setting up external keycloak #311
+43
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-rocheleau
requested changes
Mar 3, 2025
Comment on lines
+22
to
+23
| SETUP_EXTERNAL_KEYCLOAK = os.getenv("BENTOV2_USE_EXTERNAL_KEYCLOAK") in ("1", "true") | ||
| USE_EXTERNAL_IDP = False if SETUP_EXTERNAL_KEYCLOAK else os.getenv("BENTOV2_USE_EXTERNAL_IDP") |
There was a problem hiding this comment.
Can't we simply use the USE_EXTERNAL_IDP variable? I don't see the use for an additional variable here.
There was a problem hiding this comment.
It is to still give someone the opportunity to have an OIDC client that is not keycloak or if they do not want to use the init-auth command (and by mistake cause changes to their keycloak)
…nfiguration details and security recommendations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test:
BENTOV2_AUTH_REALMaccordinglyBENTOV2_AUTH_ADMIN_USER&BENTOV2_AUTH_ADMIN_PASSWORDBENTOV2_USE_EXTERNAL_KEYCLOAKin local.env as 1