-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: S3 compatibility #306
base: releases/v19
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just missing docs now.
I think we could have a general docs/object_storage.md
document that covers how to configure Bento's services for S3 storage backends. Then we can link to this document from the other docs sections.
Started work to make WES work with Drop-Box and DRS over the network only for S3 compatibility. Updated the WES version to use the PR. Hacky solution at the moment, but it works with Katsu workflows when Drop-Box is using S3. NOTE: For the WES PR to work with S3 drop-box, you need to add the |
set s3 config for drop-box
Works with the dropbox pr "s3 support" => bento-platform/bento_drop_box_service#63
Need to add some documentation.
But if you want to test =>
If s3 params are set, drop-box will use minio/s3.
if not, drop-box will use the filesystem.
The S3 params to set are =>
BENTO_DROP_BOX_S3_ENDPOINT=''
BENTO_DROP_BOX_S3_BUCKET=''
BENTO_DROP_BOX_S3_ACCESS_KEY=''
BENTO_DROP_BOX_S3_SECRET_KEY=''