Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron testing through karma. #107

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

orther
Copy link

@orther orther commented Jun 8, 2016

#90

@orther
Copy link
Author

orther commented Jun 8, 2016

I'm not sure why CircleCI is failing on npm install but I don't have time to look into it right now.

@bensu
Copy link
Owner

bensu commented Jun 8, 2016

Can you trigger a rebuild?

@orther
Copy link
Author

orther commented Jun 8, 2016

Done.

@bensu
Copy link
Owner

bensu commented Jun 8, 2016

Thanks.

Looks good to me. I'll merge once we get the tests passing (which is probably npm shenanigans)

@orther
Copy link
Author

orther commented Jun 8, 2016

Yeah I'm thinking the same thing (npm issues). I'll try trigger a build in a few hours before bed. If that doesn't work I'll try to find some time to look into it further.

@orther
Copy link
Author

orther commented Jun 8, 2016

I ssh'd into the CircleCI container to troubleshoot the npm install of slimerjs and it seems the issue is with verifying the SSL cert of download.slimerjs.org. Before I dig into figuring out how to fix this I wanted to ask did you ever have this issue with your builds? If yes, do you have a simple solution?

Does anyone have a simple solution?


For reference here is the error message from wget:

ubuntu@box5:~/doo/library$ wget  https://download.slimerjs.org/releases/0.9.6/slimerjs-0.9.6-linux-x86_64.tar.bz2
--2016-06-08 13:27:54--  https://download.slimerjs.org/releases/0.9.6/slimerjs-0.9.6-linux-x86_64.tar.bz2
Resolving download.slimerjs.org (download.slimerjs.org)... 176.31.242.138
Connecting to download.slimerjs.org (download.slimerjs.org)|176.31.242.138|:443... connected.
ERROR: cannot verify download.slimerjs.org's certificate, issued by `/C=FR/ST=Ile de France/L=Fontenay Sous Bois/O=Innophi/CN=Innophi Certification Authority/[email protected]':
  Unable to locally verify the issuer's authority.
    ERROR: certificate common name `whisky.jelix.org' doesn't match requested host name `download.slimerjs.org'.
To connect to download.slimerjs.org insecurely, use `--no-check-certificate'.

For reference here is the npm install slimerjs error:

ubuntu@box5:~/doo/library$ npm install slimerjs
npm WARN package.json [email protected] No description
npm WARN package.json [email protected] No repository field.
npm WARN package.json [email protected] No README data
npm WARN package.json [email protected] No license field.
npm WARN engine [email protected]: wanted: {"node":">=0.10.40"} (current: {"node":"0.10.33","npm":"2.13.5"})
npm WARN engine [email protected]: wanted: {"node":">=0.10.40"} (current: {"node":"0.10.33","npm":"2.13.5"})
npm WARN engine [email protected]: wanted: {"node":">=0.10.40"} (current: {"node":"0.10.33","npm":"2.13.5"})

> [email protected] install /home/ubuntu/doo/library/node_modules/slimerjs
> node install.js

SlimerJS not found on PATH
Downloading https://download.slimerjs.org/releases/0.9.6/slimerjs-0.9.6-linux-x86_64.tar.bz2
Saving to /tmp/slimerjs/slimerjs-0.9.6-linux-x86_64.tar.bz2
Receiving...

Error requesting archive.
Status: 403
Request options: {
  "uri": "https://download.slimerjs.org/releases/0.9.6/slimerjs-0.9.6-linux-x86_64.tar.bz2",
  "encoding": null,
  "followRedirect": true,
  "headers": {
    "User-Agent": "npm/2.13.5 node/v0.10.33 linux x64"
  },
  "strictSSL": true
}
Response headers: {
  "date": "Wed, 08 Jun 2016 13:20:03 GMT",
  "server": "Apache/2.2.22 (Debian)",
  "strict-transport-security": "max-age=15768000",
  "vary": "Accept-Encoding",
  "content-length": "252",
  "keep-alive": "timeout=5, max=100",
  "connection": "Keep-Alive",
  "content-type": "text/html; charset=iso-8859-1"
}
Make sure your network and proxy settings are correct.

If you continue to have issues, please report this full log at https://github.com/graingert/slimerjs
npm ERR! Linux 3.13.0-86-generic
npm ERR! argv "node" "/home/ubuntu/nvm/v0.10.33/bin/npm" "install" "slimerjs"
npm ERR! node v0.10.33
npm ERR! npm  v2.13.5
npm ERR! code ELIFECYCLE

npm ERR! [email protected] install: `node install.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] install script 'node install.js'.
npm ERR! This is most likely a problem with the slimerjs package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node install.js
npm ERR! You can get their info via:
npm ERR!     npm owner ls slimerjs
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /home/ubuntu/doo/library/npm-debug.log

Brandon Orther added 5 commits June 8, 2016 15:31
Switching between Ubuntu versions on CircleCI requires a commit to trigger the build so this useless change is what I'm using.

The reason I am trying Ubuntu 14.04 is to see if it solves the slimerjs download problems.
@bensu
Copy link
Owner

bensu commented Jun 19, 2016

Hey @orther

I tried running the tests again and we've made some progress. The Slimerjs issues were probably due to something broken on their end, and I would remove the new slimerjs installation commands.

I do see that electron-advanced didn't work and there were other unrelated failures. I will refactor the integration tests so that the failure messages are more useful. In the meantime, can you check if the advanced build for electron works?

@orther
Copy link
Author

orther commented Jun 20, 2016

Yeah I noticed the advanced failing too and have been meaning to look into
it. I'm trying to stay away from the computer for a few days but if I end
up on one (I always seem to) I'll try to fix that. Either way at the latest
I should have it looked at by the middle-end of the week.
On Jun 18, 2016 11:45 PM, "Sebastian Bensusan" [email protected]
wrote:

Hey @orther https://github.com/orther

I tried running the tests again and we've made some progress. Slimerjs was
probably something broken on their end, and I would remove it. I do see
that electron-advanced didn't work and there were other, unrelated
failures. I will refactor the integration tests so that the failure
messages are more useful. In the meantime, can you check if the advanced
build for electron works?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#107 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAHtHFKkwbJJl5P32e5nI1tAStQWNG9lks5qNOWDgaJpZM4IwiSt
.

@orther
Copy link
Author

orther commented Jun 29, 2016

Sorry for delay I am still trying to get this fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants