Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TypeScript implementation of the library #59

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

joecoolish
Copy link

First stab at a TypeScript implementation of the library. The comments might not have fully gotten ported over, but I'm pretty sure the logic is all there!

First stab at a TypeScript implementation of the library.  The comments might not have fully gotten ported over, but I'm pretty sure the logic is all there!
@benmarch
Copy link
Owner

😲 Wow!! This is awesome! Let's get it all set up with separate modules and hooked into the build script. I do want to tackle the positioning issues before porting everything, but after that I will start integrating this. Thanks!

@joecoolish
Copy link
Author

Which position issues are you still seeing? I have notice 2. The one I commented on, which is fixed by adding left: 0; to the left blackout box, and an overlapping border caused by rounding. The fix I found for that was to round all of the positions.

I can work on separating the different classes into individual files. I'm also working on making the backdrop fade in/out.

I'm using this in one of my projects ATM, so I'm invested in making it better

@joecoolish
Copy link
Author

Ok, I fixed a couple of bugs in this PR. I'm now running the TS in my project and it is fully functional. I'll start working on the backdrop, making it more polished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants