Sourcery Starbot ⭐ refactored benmack/nasa_hls#6
Open
SourceryAI wants to merge 1 commit intobenmack:masterfrom
Open
Sourcery Starbot ⭐ refactored benmack/nasa_hls#6SourceryAI wants to merge 1 commit intobenmack:masterfrom
SourceryAI wants to merge 1 commit intobenmack:masterfrom
Conversation
SourceryAI
commented
Jun 1, 2020
Comment on lines
-12
to
+18
| return sorted(set( | ||
| line.partition('#')[0].strip() | ||
| for line in open(os.path.join(os.path.dirname(__file__), file)) | ||
| ) - set('')) | ||
| return sorted( | ||
| { | ||
| line.partition('#')[0].strip() | ||
| for line in open(os.path.join(os.path.dirname(__file__), file)) | ||
| } | ||
| - set('') | ||
| ) |
Author
There was a problem hiding this comment.
Function parse_requirements refactored with the following changes:
- Replace list(), dict() or set() with comprehension
Comment on lines
-163
to
+166
| if mask_path is not None: | ||
| if Path(mask_path).exists() and not overwrite: | ||
| print("Processing skipped. File exists.") | ||
| return 0 | ||
|
|
||
| if mask_path is not None and Path(mask_path).exists() and not overwrite: | ||
| print("Processing skipped. File exists.") | ||
| return 0 | ||
|
|
Author
There was a problem hiding this comment.
Function hls_qa_layer_to_mask refactored with the following changes:
- Merge nested if conditions
Comment on lines
-233
to
+232
| tiles = str(txt)[2:-5].split("\\r\\n") | ||
| return tiles | ||
| return str(txt)[2:-5].split("\\r\\n") |
Author
There was a problem hiding this comment.
Function get_available_tiles_from_url refactored with the following changes:
- Inline variable that is only used once
Comment on lines
-259
to
+257
| hls_dataset_url = f"{base_url}/{version}/{product}/{year}/{tile[:2]}/{tile[2]}/{tile[3]}/{tile[4]}/{file_name}" | ||
|
|
||
| return hls_dataset_url | ||
| return f"{base_url}/{version}/{product}/{year}/{tile[:2]}/{tile[2]}/{tile[3]}/{tile[4]}/{file_name}" |
Author
There was a problem hiding this comment.
Function parse_url refactored with the following changes:
- Inline variable that is only used once
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨
Here's your pull request refactoring your most popular Python repo.
If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run: