Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 [security] Update express 4.17.1 β†’ 4.19.2 (minor) #44

Closed
wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link

@depfu depfu bot commented Mar 25, 2024


🚨 Your current dependencies have known security vulnerabilities 🚨

This dependency update fixes known security vulnerabilities. Please see the details below and assess their impact carefully. We recommend to merge and deploy this as soon as possible!


Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ express (4.17.1 β†’ 4.19.2) Β· Repo Β· Changelog

Security Advisories 🚨

🚨 Express.js Open Redirect in malformed URLs

Impact

Versions of Express.js prior to 4.19.2 and pre-release alpha and beta versions before 5.0.0-beta.3 are affected by an open redirect vulnerability using malformed URLs.

When a user of Express performs a redirect using a user-provided URL Express performs an encode using encodeurl on the contents before passing it to the location header. This can cause malformed URLs to be evaluated in unexpected ways by common redirect allow list implementations in Express applications, leading to an Open Redirect via bypass of a properly implemented allow list.

The main method impacted is res.location() but this is also called from within res.redirect().

Patches

0867302
0b74695

An initial fix went out with [email protected], we then patched a feature regression in 4.19.1 and added improved handling for the bypass in 4.19.2.

Workarounds

The fix for this involves pre-parsing the url string with either require('node:url').parse or new URL. These are steps you can take on your own before passing the user input string to res.location or res.redirect.

References

#5539
koajs/koa#1800
https://expressjs.com/en/4x/api.html#res.location

🚨 qs vulnerable to Prototype Pollution

qs before 6.10.3, as used in Express before 4.17.3 and other products, allows attackers to cause a Node process hang for an Express application because an __ proto__ key can be used. In many typical Express use cases, an unauthenticated remote attacker can place the attack payload in the query string of the URL that is used to visit the application, such as a[proto]=b&a[proto]&a[length]=100000000. The fix was backported to qs 6.9.7, 6.8.3, 6.7.3, 6.6.1, 6.5.3, 6.4.1, 6.3.3, and 6.2.4 (and therefore Express 4.17.3, which has "deps: [email protected]" in its release description, is not vulnerable).

Release Notes

4.19.2

What's Changed

Full Changelog: 4.19.1...4.19.2

4.19.0

What's Changed

New Contributors

Full Changelog: 4.18.3...4.19.0

4.18.3

Main Changes

Other Changes

New Contributors

Full Changelog: 4.18.2...4.18.3

4.18.2

4.18.1

  • Fix hanging on large stack of sync routes

4.18.0

4.17.3

4.17.2

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ accepts (indirect, 1.3.7 β†’ 1.3.8) Β· Repo Β· Changelog

Release Notes

1.3.8

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ body-parser (indirect, 1.19.0 β†’ 1.20.2) Β· Repo Β· Changelog

Release Notes

1.20.2

  • Fix strict json error message on Node.js 19+
  • deps: content-type@~1.0.5
    • perf: skip value escaping when unnecessary
  • deps: [email protected]

1.20.1 (from changelog)

1.20.0

1.19.2

1.19.1

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ bytes (indirect, 3.1.0 β†’ 3.1.2) Β· Repo Β· Changelog

Release Notes

3.1.2 (from changelog)

  • Fix return value for un-parsable strings

3.1.1 (from changelog)

  • Fix "thousandsSeparator" incorrecting formatting fractional part

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ content-disposition (indirect, 0.5.3 β†’ 0.5.4) Β· Repo Β· Changelog

Release Notes

0.5.4

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ content-type (indirect, 1.0.4 β†’ 1.0.5) Β· Repo Β· Changelog

Release Notes

1.0.5

  • perf: skip value escaping when unnecessary

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ cookie (indirect, 0.4.0 β†’ 0.6.0) Β· Repo Β· Changelog

Release Notes

0.6.0 (from changelog)

  • Add partitioned option

0.5.0

  • Add priority option
  • Fix expires option to reject invalid dates
  • pref: improve default decode speed
  • pref: remove slow string split in parse

0.4.2

  • pref: read value only when assigning in parse
  • pref: remove unnecessary regexp in parse

0.4.1

  • Fix maxAge option to reject invalid values

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ depd (indirect, 1.1.2 β†’ 2.0.0) Β· Repo Β· Changelog

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ destroy (indirect, 1.0.4 β†’ 1.2.0) Β· Repo Β· Changelog

Release Notes

1.2.0 (from changelog)

  • Add suppress argument

1.1.1 (from changelog)

  • Work around Zlib close bug in Node.js < 4.5.5

1.1.0 (from changelog)

  • Add Zlib steam support and Node.js leak work around

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ finalhandler (indirect, 1.1.2 β†’ 1.2.0) Β· Repo Β· Changelog

Release Notes

1.2.0

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ forwarded (indirect, 0.1.2 β†’ 0.2.0) Β· Repo Β· Changelog

Release Notes

0.2.0

  • Use req.socket over deprecated req.connection

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ http-errors (indirect, 1.7.2 β†’ 2.0.0) Β· Repo Β· Changelog

Release Notes

2.0.0 (from changelog)

  • Drop support for Node.js 0.6
  • Remove I'mateapot export; use ImATeapot instead
  • Remove support for status being non-first argument
  • Rename UnorderedCollection constructor to TooEarly
  • deps: [email protected]
    • Replace internal eval usage with Function constructor
    • Use instance methods on process to check for listeners
  • deps: [email protected]
    • Fix messaging casing of 418 I'm a Teapot
    • Remove code 306
    • Rename 425 Unordered Collection to standard 425 Too Early

1.8.1 (from changelog)

1.8.0 (from changelog)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ negotiator (indirect, 0.6.2 β†’ 0.6.3) Β· Repo Β· Changelog

Release Notes

0.6.3 (from changelog)

  • Revert "Lazy-load modules from main entry point"

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ on-finished (indirect, 2.3.0 β†’ 2.4.1) Β· Repo Β· Changelog

Release Notes

2.4.1

  • Fix error on early async hooks implementations

2.4.0

  • Prevent loss of async hooks context

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ proxy-addr (indirect, 2.0.6 β†’ 2.0.7) Β· Repo Β· Changelog

Release Notes

2.0.7

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ raw-body (indirect, 2.4.0 β†’ 2.5.2) Β· Repo Β· Changelog

Release Notes

2.5.2 (from changelog)

  • Fix error message for non-stream argument

2.5.1 (from changelog)

  • Fix error on early async hooks implementations

2.5.0 (from changelog)

2.4.3 (from changelog)

2.4.2 (from changelog)

2.4.1 (from changelog)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ send (indirect, 0.17.1 β†’ 0.18.0) Β· Repo Β· Changelog

Release Notes

0.18.0 (from changelog)

0.17.2 (from changelog)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ serve-static (indirect, 1.14.1 β†’ 1.15.0) Β· Repo Β· Changelog

Release Notes

1.15.0

1.14.2

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ setprototypeof (indirect, 1.1.1 β†’ 1.2.0) Β· Repo

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ statuses (indirect, 1.5.0 β†’ 2.0.1) Β· Repo Β· Changelog

Release Notes

2.0.1 (from changelog)

  • Fix returning values from Object.prototype

2.0.0 (from changelog)

  • Drop support for Node.js 0.6
  • Fix messaging casing of 418 I'm a Teapot
  • Remove code 306
  • Remove status[code] exports; use status.message[code]
  • Remove status[msg] exports; use status.code[msg]
  • Rename 425 Unordered Collection to standard 425 Too Early
  • Rename STATUS_CODES export to message
  • Return status message for statuses(code) when given code

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ toidentifier (indirect, 1.0.0 β†’ 1.0.1) Β· Repo Β· Changelog

Commits

See the full diff on Github. The new version differs by more commits than we can show here.


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

Copy link
Author

depfu bot commented Sep 10, 2024

Closed in favor of #46.

@depfu depfu bot closed this Sep 10, 2024
@depfu depfu bot deleted the depfu/update/npm/express-4.19.2 branch September 10, 2024 20:14
Copy link
Author

depfu bot commented Sep 10, 2024

Closed in favor of #46.

2 similar comments
Copy link
Author

depfu bot commented Sep 10, 2024

Closed in favor of #46.

Copy link
Author

depfu bot commented Sep 10, 2024

Closed in favor of #46.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant