New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor numeric constants (Earth radius) #86

Merged

benbovy merged 1 commit into main from refactor-constants

Dec 9, 2024

Owner

benbovy commented Dec 9, 2024

Small PR.

constants defined under numeric_constants struct using static constexpr
Earth radius: reuse value defined in s2geometry's S2Earth (for consistency if we later also reuse utility functions defined in S2Earth).


          refactor numeric constants (earth radius)

40dc1de

Reuse values defined in s2geometry's S2Earth.

benbovy changed the title ~~Refactor numeric constants (earth radius)~~ Refactor numeric constants (Earth radius)

jorisvandenbossche approved these changes

View reviewed changes

benbovy merged commit 8fa60ae into main

14 of 15 checks passed

benbovy deleted the refactor-constants branch

December 9, 2024 14:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet